Skip to content

Mumble fixes#189

Open
kaitlynia wants to merge 3 commits intoTaterClient:masterfrom
kaitlynia:patch-3
Open

Mumble fixes#189
kaitlynia wants to merge 3 commits intoTaterClient:masterfrom
kaitlynia:patch-3

Conversation

@kaitlynia
Copy link

@kaitlynia kaitlynia commented Feb 26, 2026

Fixes Mumble plugin, wasn't working before. Also scales the distances so that they are usable for Mumble's defaults.

Checklist

  • Tested the change ingame
  • Provided screenshots if it is a visual change
  • Tested in combination with possibly related configuration options
  • Written a unit test (especially base/) or added coverage to integration test
  • Considered possible null pointers and out of bounds array indexing
  • Changed no physics that affect existing maps
  • Tested the change with ASan+UBSan or valgrind's memcheck (optional)
  • I didn't use generative AI to generate more than single-line completions

Since DDNet stores positional data as 32 units per tile, we need to scale this down for Mumble so the defaults for positional audio are reasonable (I chose 4 tiles = 1 meter)
@kaitlynia kaitlynia changed the title Patch 3 Mumble fixes Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant