MacOS support#2
Conversation
It seems like you need to remove the \u{1} from the autogenerate bindgen code to make it work on all platforms. Will test on Windows and Linux to see if this works
|
Thank you for your contribution! The issue with the Ideally I would want to avoid any manual cleanup of the generated bindings though. Maybe bindgen can be persuaded to generate the link names without the prefix? Alternatively a post processing step like the one to replace the typedefs would be ok if bindgen cannot do it natively. The option Also, I probably should look into setting up CI to test for such platform dependent changes. Since I don't have a Mac I cannot test on Mac myself. CI with Matlab seems to be possible, but preliminary experimentation didn't work out that well for me. In the meantime please rebase your changes onto |
|
Hey, I just rebased your fork onto dev and created a new branch. Besides one small conflict with a change unrelated to Mac support there is no conflict with any code you have written/changed. I also added CI with MacOS on top of your fork so it should be easy to see for everyone if your fork works for Mac. If you do further work on this issue, please base it on top of the mentioned new branch I created from your fork to allow an easy merge into dev after you are done. As I said above I really don't want to add manual labour when creating the bindings. Before I am willing to merge your fork I would like to have some solution to avoid this. Sadly it seems |
These changes feel a bit hacky, but it seems like you need to remove the \u{1} from the autogenerate bindgen code to make it work on all platforms. I tested this on MacOS, Windows 10 and Linux (Ubuntu 20.04) and it all seems to work and function as expected. I ran the xtask test and it seemed to work just fine.
To be honest I'm not sure if this is the correct solution, or if there is a bindgen setting that will always generate universal bindings or generate those bindings at compile time?