Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool call IDs can repeat across messages. DCP previously reused the first call's metadata and applied one pruning flag to multiple results, which could remove the newest output. V2 projection could also associate a call with a later turn's result.
Retain calls with ambiguous IDs during automatic pruning and sweep, discard unsafe existing flags, scope subagent caches by message/part, and pair V2 results with their preceding calls. Unique IDs keep their existing behavior; provider IDs and the persisted state format are unchanged. Ambiguous calls intentionally retain more context.
Fixes #615.
Validation:
npm test: 133 DCP tests and 8 request-logger tests passed. The 14 new regressions have 12 failures on the unchanged baseline and all pass with this change.npm run typecheck,npm run check:package, andnpm run format:checkpassed.Known baseline checks:
npm audit --audit-level=highfails on the unchanged lockfile as well, including high advisories for transitivebrace-expansion@2.1.4. No dependencies were changed. An initial parallel run timed out in an unchanged logger watcher test; standalone and sequential reruns passed. Docker lab and live providers were not run.AI assistance was used to prepare the implementation and tests.