[NPE] Add GCP Pubsub Support - #72
Merged
Merged
Conversation
ojameso
force-pushed
the
npe/add_pubsub
branch
2 times, most recently
from
August 14, 2025 21:34
3077b4c to
a783675
Compare
ojameso
force-pushed
the
npe/add_pubsub
branch
from
August 14, 2025 22:45
43620e6 to
d613892
Compare
ojameso
marked this pull request as ready for review
August 14, 2025 22:45
ojameso
requested review from
a team and
captainkevron
and removed request for
a team
August 14, 2025 22:45
ojameso
force-pushed
the
npe/add_pubsub
branch
5 times, most recently
from
August 15, 2025 22:05
e6f898e to
4e165ea
Compare
ojameso
force-pushed
the
npe/add_pubsub
branch
from
August 15, 2025 22:22
4e165ea to
46c98b9
Compare
captainkevron
left a comment
captainkevron
left a comment
Contributor
There was a problem hiding this comment.
Couple small questions. I am not very familiar with the Chore architecture, so I mostly used the SQS implementation as a reference to compare against. Nice work on the README.md updates.
obrie
requested changes
Aug 20, 2025
ojameso
force-pushed
the
npe/add_pubsub
branch
from
August 28, 2025 01:25
a62893b to
e7acd81
Compare
ojameso
force-pushed
the
npe/add_pubsub
branch
from
September 3, 2025 23:59
e7acd81 to
90ee32c
Compare
ojameso
force-pushed
the
npe/add_pubsub
branch
from
September 4, 2025 00:07
90ee32c to
c7b651c
Compare
obrie
reviewed
Sep 5, 2025
obrie
reviewed
Sep 5, 2025
obrie
approved these changes
Sep 5, 2025
obrie
left a comment
obrie
left a comment
Member
There was a problem hiding this comment.
All of my comments are nice-to-have cleanup. Functionally everything looks good here. Going to approve as-is and leave it up to you how much cleanup you want to do.
ojameso
force-pushed
the
npe/add_pubsub
branch
from
September 9, 2025 00:47
f485794 to
87b2efd
Compare
ojameso
force-pushed
the
npe/add_pubsub
branch
from
September 9, 2025 20:28
87b2efd to
850df19
Compare
[NPE-719] Add PayloadHandler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds GCP PubSub support.
Adds both
Chore::Queues::PubSub::ConsumerandChore::Queues::PubSub::Producer. this can be configured numerous ways. Interesting notes regarding configuration have been added to the README.Breaking change
Nonbreaking change
Testing