Skip to content

add Docker build and push steps to CI workflow - #6

Merged
youssef-ar merged 1 commit into
mainfrom
feature/cicd
Apr 3, 2026
Merged

youssef-ar merged 1 commit into
mainfrom
feature/cicd

Conversation

@youssef-ar

@youssef-ar youssef-ar commented Apr 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Optimized CI/CD pipeline with concurrent run management and automated Docker image builds for pull requests and deployments.

@coderabbitai

coderabbitai Bot commented Apr 3, 2026 •

Copy link
Copy Markdown
ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Free

Run ID: 8c658d4c-b736-4a7d-87ce-c876898ddc06

📥 Commits

Reviewing files that changed from the base of the PR and between c85bb5e and 7e0a88b.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The pull request adds workflow-level concurrency to the CI pipeline and introduces a new docker-build job that conditionally builds and pushes Docker images to Docker Hub for main branch commits while building without pushing for pull requests.

Changes

Cohort / File(s) Summary
CI/CD Workflow Enhancement
.github/workflows/ci.yml
Adds workflow concurrency configuration to cancel superseded runs; introduces docker-build job with dependencies on test and lint jobs. Implements conditional Docker Buildx setup with PR-specific image builds (tag: ingestion:pr-<sha>) and main-branch pushes to Docker Hub using secrets with dual tags (<username>/ingestion:<sha> and latest). Includes registry-based build cache configuration.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A docker in the workflow hops with glee,
Building images for all to see,
On main it pushes, on PRs it builds with care,
With caches and tags floating through the air! 🐳


Note

🎁 Summarized by CodeRabbit Free

The PR author is not assigned a seat. To perform a comprehensive line-by-line review, please assign a seat to the pull request author through the subscription management page by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented Apr 3, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots

See analysis details on SonarQube Cloud

@youssef-ar
youssef-ar merged commit 971b34f into main Apr 3, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant