Refactor file extension extraction and consolidate test helpers#1896
Open
Mbeaulne wants to merge 1 commit into03-04-bulk_argument_upload_-_template_selectionfrom
Open
Refactor file extension extraction and consolidate test helpers#1896Mbeaulne wants to merge 1 commit into03-04-bulk_argument_upload_-_template_selectionfrom
Mbeaulne wants to merge 1 commit into03-04-bulk_argument_upload_-_template_selectionfrom
Conversation
🎩 To tophat this PR:You can add the following URL parameter to your browser to tophat this PR: |
This was referenced Mar 4, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Refactored file import functionality by extracting a reusable
getFileExtensionutility function and consolidating duplicate test helper functions. ThegetFileExtensionfunction replaces inline file extension parsing logic in bothOasisSubmitterandSubmitTaskArgumentsDialogcomponents. Additionally, created a sharedFileImportResultinterface to unify the return types between CSV and JSON import functions, and moved common test helper functions (makeSecretArgandmakeInput) to a dedicatedtestHelpers.tsfile.Type of Change
Checklist
Test Instructions
Additional Comments
This refactoring improves code maintainability by eliminating duplicate logic and providing better type safety through shared interfaces. The changes are purely structural and should not affect the user-facing functionality.