Skip to content

Add YAML file import support to task arguments dialog #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mbeaulne wants to merge 1 commit into
base: 03-04-bulk_argument_upload_-_json
Choose a base branch
from
+17 −5
Open

Add YAML file import support to task arguments dialog #1894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/components/shared/Submitters/Oasis/components/SubmitTaskArgumentsDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { useMutation } from "@tanstack/react-query";
import yaml from "js-yaml";
import { type ChangeEvent, type KeyboardEvent, useRef, useState } from "react";

import type { TaskSpecOutput } from "@/api/types.gen";
Expand Down Expand Up @@ -138,16 +139,27 @@ export const SubmitTaskArgumentsDialog = ({
};

const handleFileImport = (fileText: string, fileExtension: string) => {
const isJson = fileExtension === ".json";
const isYaml = fileExtension === ".yaml" || fileExtension === ".yml";
const isJson = fileExtension === ".json" || isYaml;

let jsonText = fileText;
if (isYaml) {
try {
jsonText = JSON.stringify(yaml.load(fileText));
} catch {
notify("YAML file contains invalid syntax", "warning");
return;
}
}

const result = isJson
? mapJsonToArguments(fileText, inputs, taskArguments)
? mapJsonToArguments(jsonText, inputs, taskArguments)
: mapCsvToArguments(fileText, inputs, taskArguments);

if (result.rowCount === 0 && result.changedInputNames.length === 0) {
notify(
isJson
? "JSON file is empty or contains invalid data"
? "File is empty or contains invalid data"
: "CSV file is empty or contains only headers",
"warning",
);
Expand Down Expand Up @@ -178,7 +190,7 @@ export const SubmitTaskArgumentsDialog = ({

let message = result.enableBulk
? `Imported ${result.rowCount} rows across ${inputCount} input${inputCount !== 1 ? "s" : ""}`
: `Imported ${inputCount} input${inputCount !== 1 ? "s" : ""} from ${isJson ? "JSON" : "CSV"}`;
: `Imported ${inputCount} input${inputCount !== 1 ? "s" : ""} from ${isJson ? (isYaml ? "YAML" : "JSON") : "CSV"}`;

if (result.unmatchedColumns.length > 0) {
const keyLabel = isJson ? "keys" : "columns";
Expand Down Expand Up @@ -668,7 +680,7 @@ const ImportFileButton = ({
<input
ref={fileInputRef}
type="file"
accept=".csv,.json"
accept=".csv,.json,.yaml,.yml"
onChange={handleFileChange}
className="hidden"
/>
Expand Down
Loading