chore: Prevent unnecessary API calls to get container execution details#1893
Open
morgan-wowk wants to merge 1 commit intomasterfrom
Open
chore: Prevent unnecessary API calls to get container execution details#1893morgan-wowk wants to merge 1 commit intomasterfrom
morgan-wowk wants to merge 1 commit intomasterfrom
Conversation
🎩 To tophat this PR:You can add the following URL parameter to your browser to tophat this PR: |
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
morgan-wowk
force-pushed
the
reduce-status-checks
branch
from
b351afd to
92e9cbb
Compare
morgan-wowk
force-pushed
the
reduce-status-checks
branch
2 times, most recently
from
1b675e5 to
2398561
Compare
morgan-wowk
force-pushed
the
reduce-status-checks
branch
from
2398561 to
b5cc879
Compare
morgan-wowk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before
After
Optimized container execution state and log fetching by preventing unnecessary API calls for containers in expected non-execution states. Added status-based conditional fetching that skips requests when containers are in states like INVALID, UNINITIALIZED, QUEUED, WAITING_FOR_UPSTREAM, or SKIPPED, where execution records and logs are not expected to exist. Refined log polling logic to only poll for actively running containers (RUNNING, PENDING, CANCELLING) while still allowing log fetches for completed states that may have logs.
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments
This change reduces unnecessary network requests and prevents potential errors when trying to fetch execution state or logs for containers that haven't been launched or were terminated before execution began. The CANCELLED status is intentionally handled carefully since tasks cancelled mid-run may have logs uploaded by the backend before termination.