Conversation
🎩 To tophat this PR:You can add the following URL parameter to your browser to tophat this PR: |
a401705 to
581055e
Compare
src/components/shared/ReactFlow/FlowCanvas/FlexNode/FlexNode.tsx
Outdated
Show resolved
Hide resolved
11b7fbf to
f3e1189
Compare
|
Screen Recording 2026-03-04 at 8.34.05 PM.mov (uploaded via Graphite) ^ BUG: when go to I/O nodes there is a lot of extra space on top |
src/components/shared/ReactFlow/FlowCanvas/Multiselect/MultiSelectPanel.tsx
Outdated
Show resolved
Hide resolved
|
We need to add "Multiselect" folder to "react-compiler" config. |
|
NIT: I don't know if its this PR or something that exists but auto layout then copy node breaks a bit. |
src/components/shared/ReactFlow/FlowCanvas/Multiselect/TaskDetailPanel.tsx
Show resolved
Hide resolved
src/components/shared/ReactFlow/FlowCanvas/FlexNode/FlexNode.tsx
Outdated
Show resolved
Hide resolved
99e0a0f to
9687d96
Compare
Fixed
Done
Looks like an issue with long titles. Fixed.
It is this PR. Specifically the button in the context panel. When clicked it uses a stale version of the spec. I had an initial look but might not be an easy fix (adding the callbacks to the |
9687d96 to
84a1401
Compare
Should now be fixed! |
84a1401 to
af35fa4
Compare


Description
Adds a specific context panel view for when multiple nodes are selected.
The new view shows a list of selected nodes followed by the standard array of multi-select toolbar actions. The nodes in the list can be selected to open their specific context panels, with a "back" button to go back to the multiselection panel.
Related Issue and Pull requests
Closes https://github.com/Shopify/oasis-frontend/issues/497
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments
This PR also refines the naming process for Sticky Notes.
There is a multiselect check added inside each of task, io and flex nodes to avoid a race condition on displaying content in the context panel.
I absolutely loathe the process for adding a new callback to a task and the extremely loose typing associated with tasks. I would love to address this as done in #928 though I also understand it may be addressed as part of the Object-Model work.
Deleting a node from with the multiselect interface and then undoing via ctrl+z will not restore the node to the select because the selection is managed by reactflow whilst undo/redo is via the component spec.