Skip to content

Plugin features: Description callback - Set parameter inside render_features_settings_page #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolas-jaussaud wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −7
Open

Plugin features: Description callback - Set parameter inside render_features_settings_page #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions plugin/features/settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,17 @@ function render_features_settings_page($plugin) {

$feature_key = framework\get_plugin_feature_key($plugin, $feature);
$is_enabled = framework\is_plugin_feature_enabled($plugin, $feature, $settings);
$settings = framework\get_plugin_settings($plugin, $feature);

if (is_callable($feature['description'] ?? '')) {
$feature['description'] = function() use($feature, $settings, $feature_key, $is_enabled) {
$feature['description'](
$settings,
$feature_key,
$is_enabled
);
};
}

?>
<div class="setting-row feature-<?php echo $name; ?>">
Expand Down
9 changes: 2 additions & 7 deletions plugin/settings/checkbox.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,8 @@ function render_setting_field_checkbox($config) {
<?php if (!empty($description)): ?>
<div class="feature-description">
<?php
if (is_callable($description)) {
$description(
tangible\framework\get_plugin_feature_settings($plugin, $feature),
tangible\framework\get_plugin_feature_settings_key($plugin, $feature),
$is_enabled
);
} else {
if (is_callable($description)) $description();
else {
echo $description;
}
?>
Expand Down