feat(errors): enforce safe API error policy#316
Merged
Conversation
|
@Jayking40 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce Safe API Error Responses
Summary
This PR centralizes API error serialization so internal exception details are not returned to clients. All terminal Express errors are mapped through the safe error message policy, with request IDs included for support correlation and redacted structured logs retained for diagnostics.
Changes
Testing
npx jest --runTestsByPath src/errors/errorMessagePolicy.integration.test.ts src/errors/appError.test.ts src/errors/safeErrors.test.ts --runInBand --silentnpx eslint src/app.ts src/index.ts src/errors/appError.ts src/errors/errorMessagePolicy.integration.test.ts src/middleware/errorHandlers.ts src/logger.tsNote: full build/lint is currently blocked by an unrelated pre-existing syntax error in
src/webhookDelivery.ts.Closes #273