fix: drop the GA4 first_open tail from the Play figures - #4
Merged
Conversation
The tail supplemented the confirmed Play total with Firebase first_open events for days Play had not reported yet, on the assumption that Play would later confirm roughly the same number. Real data disproved the assumption: first_open fires on reinstalls, data wipes and the first launch after an SDK rollout, so the panel counted 10 "installs" on a day Play confirmed zero — and the lifetime figure visibly fell every time Play caught up and the inflated days left the query window. A lifetime count that goes down is worse than one that runs a few days behind. The panel now shows only what Play has confirmed, dated by the report day it comes from. At the volumes this widget watches, the two-to-three day report lag costs nothing; the phantom installs cost trust. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQfMsv3osfTrJbDnCnSxJa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The panel's Google number visibly fell (25 → 15) whenever Play's reports caught up. Root cause: the GA4 supplement counted Firebase
first_openevents as installs for days Play had not reported yet, andfirst_openis not an install — it fires on reinstalls, data wipes and the first launch after an SDK rollout.Proven against real data:
Every time Play published a day, the inflated GA4 estimate for it left the query window and the "lifetime" total dropped. A lifetime count that goes down is worse than one that runs a few days behind — and at this widget's volumes the 2–3-day Play lag costs nothing.
What
GoogleAnalyticsClient,GoogleAnalyticsInstallsServiceand their testsFiguresModel; the Google row is now Play-onlyWidgetSettings, its validators fromStoreCredentials, and its assembly fromStoreAccountsGoogleServiceAccountToken.maketo its pre-GA4 shape (no scope parameter)Verification
swift buildclean, 130/130 tests passlifetime=7 today=0 asOf=2026-08-04, matching Play Console🤖 Generated with Claude Code
https://claude.ai/code/session_01UQfMsv3osfTrJbDnCnSxJa