Fix FK metadata loading#245
Merged
Merged
Conversation
Collaborator
|
Thanks for this PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix PostgreSQL foreign key metadata loading by swapping the
information_schemaFK query for apg_catalogone.The old query sometimes failed to load certain foreign keys — depending on how PostgreSQL exposed things through
information_schema. When that happened, the FK buttons just disappeared from the UI.The new query reads directly from PostgreSQL system catalogs (
pg_constraint,pg_attribute,pg_class,pg_namespace) and correctly handles:Changes
information_schemaFK query withpg_catalogqueryTesting
Ran:
cargo test test_postgres_foreign_keys_via_pg_catalog -- --ignoredAlso manually checked that FK buttons and navigation work in the editor UI.
Closes #244