-
-
Notifications
You must be signed in to change notification settings - Fork 329
feat(ssh): forward a tunnel to a Unix socket on the remote server (#1871) #1876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| // | ||
| // LibSSH2ForwardChannel.swift | ||
| // TablePro | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| import CLibSSH2 | ||
|
|
||
| /// Opens the channel that carries forwarded traffic to the destination. The two libssh2 | ||
| /// entry points behave identically to the caller: both return a channel that reads and | ||
| /// writes the same way, and both signal "not ready yet" with `LIBSSH2_ERROR_EAGAIN`. | ||
| internal enum LibSSH2ForwardChannel { | ||
| static func open( | ||
| session: OpaquePointer, | ||
| destination: SSHForwardDestination, | ||
| originPort: Int | ||
| ) -> OpaquePointer? { | ||
| switch destination { | ||
| case .tcp(let host, let port): | ||
| return libssh2_channel_direct_tcpip_ex( | ||
| session, | ||
| host, | ||
| Int32(port), | ||
| Self.originHost, | ||
| Int32(originPort) | ||
| ) | ||
| case .unixSocket(let path): | ||
| return libssh2_channel_direct_streamlocal_ex( | ||
| session, | ||
| path, | ||
| Self.originHost, | ||
| Int32(originPort) | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| private static let originHost = "127.0.0.1" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // | ||
| // SSHForwardDestination.swift | ||
| // TablePro | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| /// What the SSH server connects to on the far end of a local forward. A TCP destination | ||
| /// opens a `direct-tcpip` channel; a socket destination opens a `direct-streamlocal@openssh.com` | ||
| /// channel, the equivalent of `ssh -L <localPort>:/path/to/socket`. | ||
| internal enum SSHForwardDestination: Sendable, Hashable { | ||
| case tcp(host: String, port: Int) | ||
| case unixSocket(path: String) | ||
|
|
||
| var isUnixSocket: Bool { | ||
| switch self { | ||
| case .tcp: return false | ||
| case .unixSocket: return true | ||
| } | ||
| } | ||
|
|
||
| var logDescription: String { | ||
| switch self { | ||
| case .tcp(let host, let port): return "\(host):\(port)" | ||
| case .unixSocket(let path): return path | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a connection uses this new key, the copied
+sshconnection URL does not round-trip it: I checkedConnectionURLFormatter.formatSSH, which still serializes onlyconnection.host/connection.portfor the database endpoint, andConnectionURLParser/applyParsedhas no socket-path field to restore. If a user copies or imports a socket-forwarded connection URL, the imported connection silently falls back to the stale Host/Port and no longer forwards to the Unix socket, so the socket path needs to be included in the URL query and applied on import.Useful? React with 👍 / 👎.