fix(plugins): revalidate the plugin registry instead of serving a stale cached list#1802
Merged
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1799.
Problem
A plugin published to the registry after an app release never showed up: the install prompt failed with "Plugin not found" and Settings > Plugins > Browse did not list it, even across relaunches. Two defects compounded:
Fix
ensureManifest(.ifStale | .mustBeCurrent); a 300s throttle and in-flight task dedup sit on top of.reloadRevalidatingCacheData, which sends a conditional GET on every real fetch (about 300 bytes on a 304). The manual ETag layer is deleted; URLCache handles validation natively.PluginError.registryUnreachableseparates "couldn't reach the registry" from a genuine "Plugin not found".Tests
New
RegistryClientFreshnessTests(9 tests, mock URLProtocol): cache-policy shape, freshness throttle, forced revalidation, in-flight dedup, cached-fallback state, and the anchor regression (stale manifest without the plugin, fresh server copy with it, install no longer throws notFound). All existing RegistryClientURLTests and PluginManagerReconciliationTests pass unchanged. swiftlint --strict clean.