Lecture view additional features by nadjajovancevic · Pull Request #390 · TU-Wien-dataLAB/grader-service

nadjajovancevic · 2026-08-24T11:52:22Z

Additional features include:

collapsible groups
global release button

Fixes:

combobox in create/edit assignment dialog works as expected: users can remove the group after it's been selected
late submissions' field in create/edit assignment dialog: the entries are being removed as expected

…ts without a group

…lecture-view # Conflicts: # packages/labextension/src/app/components/grader-service/assignments/assignment-group.tsx # packages/labextension/style/css/output.css

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

see: https://stackblitz.com/edit/shadcn-combobox-example?file=app%2Fpage.tsx

…release them in one

…onal-features-dialog-overflow fix: overflowing text for release, delete, edit dialogs

…-Wien-dataLAB/grader-service into feat/lecture-view-additional-features

…b.com/TU-Wien-dataLAB/grader-service into feat/lecture-view-additional-features # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

…-Wien-dataLAB/grader-service into feat/lecture-view-additional-features

…l-features

nadjajovancevic · 2026-08-25T08:50:12Z

I looked through the design again, and I think that we need this component only for the release dialog. Maybe it would be also fine if we just migrate this component to release-dialog.tsx? :)

Make sense, I just moved that out to make release-dialog component more shorten so it looks easier to read and understand. Should I move that in? ))

nadjajovancevic · 2026-08-25T08:50:54Z

+      case 'released':
+        return <ReleasedAssignmentBadge />;
+      case 'complete':
+        return <Badge>Completed</Badge>;


There is a CompletedAssignmentBadge component that we can use here :)

Sure, I'll use that ))

nadjajovancevic · 2026-08-25T09:02:46Z

+    if (!props.assignments) {
+      return 'Release assignments';
+    }
+
+    if (props.isAssignmentsGrouped || Array.isArray(props.assignments)) {
+      return 'Release assignments';
+    }
+
+    if (typeof props.assignments === 'object' && props.assignments.name) {
+      return `Release ${props.assignments.name}`;
+    }
+
+    return 'Release assignments';


I might be missing something, but I am a bit confused regarding the checks here. I don't know if the suggestion would be correct, I tried it out and it seemed to work fine as well :) But please correct me if I am missing something!

Suggested change

if (!props.assignments) {

return 'Release assignments';

}

if (props.isAssignmentsGrouped || Array.isArray(props.assignments)) {

return 'Release assignments';

}

if (typeof props.assignments === 'object' && props.assignments.name) {

return `Release ${props.assignments.name}`;

}

return 'Release assignments';

if (props.isAssignmentsGrouped || Array.isArray(props.assignments)) {

return 'Release assignments';

}

return `Release ${props.assignments.name}`;

Yeah, make sense, looks good. Let me check all test cases with version ))

nadjajovancevic · 2026-08-25T09:06:52Z

+    onSubmit: async ({ value }) => {
+      if (props.isAssignmentsGrouped) {
+        const flatAssignments = Object.values(props.assignments).flat();
+        await handleAssignmentsRelease(flatAssignments, props.lectureId);
+      }
+      if (Array.isArray(props.assignments)) {
+        await handleAssignmentsRelease(props.assignments, props.lectureId);
+      } else {
+        await handleRelease(props.assignments, props.lectureId);
+      }
+      props.setOpenDialog(false);
+    }


I know it might seem weird, but the hooks (handleAssignmentsRelease and handleRelease) are actually not asynchronous, since we use mutate in the background and not mutateAsync. So the await and async operators are not necessary here :)

oh, really. Okk I'll look again and fix this moment )

nadjajovancevic · 2026-08-25T09:16:52Z

+          style={{ wordBreak: 'break-all' }}
          className={
            'flex flex-col p-6 gap-4 items-start self-stretch border-t border-border'


Suggested change

style={{ wordBreak: 'break-all' }}

className={

'flex flex-col p-6 gap-4 items-start self-stretch border-t border-border'

className={

'flex flex-col p-6 gap-4 items-start self-stretch border-t border-border break-all'

does it work? just that option wasn't working on my end

nadjajovancevic · 2026-08-25T09:17:34Z

+          style={{ wordBreak: 'break-all' }}
          className={
            'flex flex-col p-6 gap-4 items-start self-stretch border-t border-border'


Suggested change

style={{ wordBreak: 'break-all' }}

className={

'flex flex-col p-6 gap-4 items-start self-stretch border-t border-border'

className={

'flex flex-col p-6 gap-4 items-start self-stretch border-t border-border break-all'

nadjajovancevic · 2026-08-25T09:25:00Z

  });

-  const handleDeleteAssignment = (assignmentId: number, lectureId: number) => {
+  const handleDeleteAssignment = async (


I don't know how this reappeared but async is not needed here :)

sure, I will remove ))

nadjajovancevic · 2026-08-25T09:26:39Z

+                    render={
+                      <span className="inline-block">
+                        <Button
+                          className={'ml-auto cursor-pointer'}


I see that cursor-pointer has been added at multiple places for button, maybe we should just add the class in the button component? :)

Yeah, make sense, I thought about that and maybe add switcher to turn on/off the cursor style

nadjajovancevic · 2026-08-25T09:28:28Z

          <DialogTitle>
            {props.assignment
-              ? `Edit ${props.assignment.name}`
+              ? `Edit ${truncateText(props.assignment.name, 40)}`
              : 'New Assignment'}
          </DialogTitle>


Could we achieve the same behavior with css classes?

I tried, but tailwind.css seems doesn't support. Or you mean css itself?

nadjajovancevic

Just a few small remarks, nothing too important :)

…async

Nadja Jovancevic and others added 30 commits July 30, 2026 15:41

Fix: show "ungrouped assignments" group only when there are assignmen…

cfca37c

…ts without a group

WIP: add assignment count to each group

a3180e8

WIP: adjust release dialog for multiple assignments

6accb31

fix: change unrelease success message

af71d21

WIP: show appropriate icon and message when there are no assignments

e484695

WIP: gray out the text when assignment is completed

1fde79d

chore: remove redundant data type declaration

9d01fc6

chore: add new lecture to the dev token config

e8d5f42

Merge branch 'refs/heads/feat/new-labextension' into feat/new-design-…

a0e705f

…lecture-view # Conflicts: # packages/labextension/src/app/components/grader-service/assignments/assignment-group.tsx # packages/labextension/style/css/output.css

refactor: remove filterGroups and adjust filters' structure

5d2046e

WIP: add "create another" checkbox to create assignment dialog

d2334e9

fix: use mutate instead of mutateAsync in assignment hooks

17369a4

fix: adjust empty states for dashboard and lecture pages

7e3a50d

fix: remove focus and active input styling from InputGroupInput

fa9137e

fix: align button correctly

ac9b04a

fix: adjust recalc scores dialog's layout

63adc01

fix: pass recalc-scores flag to updateAssignment mutation

5c8f197

chore: clean up styling files

2204869

fix: change input time formatting

0d71ec0

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

feat: make group collapsible

be04d64

fix: late submissions field deletion

5dd9f52

WIP: replace creatable combobox with new shadcn combobox

062c5af

see: https://stackblitz.com/edit/shadcn-combobox-example?file=app%2Fpage.tsx

feat: migrate group assignments selection state to a parent state to …

4ea761e

…release them in one

feat: support releasing multiple assignment groups

01ce358

feat: add drop block to collapsed groups and fix bugs

2444b5b

revert: get back 5dd9f52 commit changes

6de6a88

revert: get back 062c5af commit changes

ac12e98

fix: overflowing text for release, delete, edit dialogs

7d7bf12

Merge pull request #388 from TU-Wien-dataLAB/feat/lecture-view-additi…

b4b2736

…onal-features-dialog-overflow fix: overflowing text for release, delete, edit dialogs

Merge branch 'feat/lecture-view-additional-features' of github.com:TU…

8d5e7de

…-Wien-dataLAB/grader-service into feat/lecture-view-additional-features

szebiniso-tuwien and others added 5 commits August 19, 2026 13:48

fix: release button tooltip displaying

858ad62

fix: align popover popup width with popover trigger width

77cbd88

Merge branch 'feat/lecture-view-additional-features' of github.com:TU…

77e7aca

…-Wien-dataLAB/grader-service into feat/lecture-view-additional-features

Merge branch 'feat/new-labextension' into feat/lecture-view-additiona…

e32ae56

…l-features

nadjajovancevic requested a review from szebiniso-tuwien August 24, 2026 11:52

szebiniso-tuwien requested a review from natkam August 24, 2026 12:47

nadjajovancevic commented Aug 25, 2026

View reviewed changes

refactoring: refactor lecture components styles and features, remove …

863d624

…async

szebiniso-tuwien approved these changes Aug 28, 2026

View reviewed changes

szebiniso-tuwien merged commit 004f4a2 into feat/new-labextension Aug 28, 2026

nadjajovancevic deleted the feat/lecture-view-additional-features branch September 23, 2026 12:51

Conversation

nadjajovancevic commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nadjajovancevic left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nadjajovancevic commented Aug 24, 2026 •

edited

Loading