New API model - #372
Open
nadjajovancevic wants to merge 4 commits into
Open
New API model#372nadjajovancevic wants to merge 4 commits into
nadjajovancevic wants to merge 4 commits into
Conversation
* chore: Add docstring to `gitlookup` method of `GitBaseHandler` * cleanup: Remove/reduce outputs from test notebooks. Adjust LimitOutput preprocessor's tests. The size of some of them was quite big. * chore: speed up some of the slowest tests Feedback generation tests don't need to run the whole pipeline of executors, so I've "mocked" the autograding process by setting up a minimal gradebook. This sped up some of the tests from e.g. ~8 s to <2 s. * chore: Add a pytest marker "slow" to the slowest tests * chore: Remove some dead code from converter tests * fix: Use url-specific method instead of `os.path` to handle a url * fix: Fix some deprecation warnings from sqlalchemy * fix: Exclude tests from coverage report * Remove deprecated attributes from KubeGraderExecutor According to the docstrings, they were supposed to be removed in v0.8. * chore: Fix a docstring * fix: Fix a typo in variable name, add a missing import * cleanup: Remove unused functions from utils * chore: Update a docstring (leftover deleted attr); improve formatting of a str
natkam
reviewed
Jun 11, 2026
| type: "integer" | ||
| format: "int64" | ||
| name: | ||
| commit_hash: |
Contributor
There was a problem hiding this comment.
We could rename it to hash or version_hash to avoid using Git terminology :)
natkam
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API model has been updated to match the requirements of the new design.
Except for introducing the new DTOs, I also defined
enumobjects forGradingMethod(previouslyautograde_type) andAssignmentStatus.After these changes have been approved, I will generate new classes using this model.
After these changes take place, refactoring the endpoints will be necessary, both in backend and frontend, after the model is finalized.