169: Remove old Bitnami chart references and values - #187
JaeYeonLee0621 wants to merge 4 commits into
Conversation
| # connections (wal_level >= replica, a pg_hba `replication` rule, and a user | ||
| # with REPLICATION privilege, e.g. the `postgres` superuser). Only takes effect | ||
| # on first creation (the Cluster must not yet exist). | ||
| bootstrapFromExternal: |
There was a problem hiding this comment.
bootstrapFromExternal:
enabled: true
connection:
# The `postgres` superuser password lives in the same secret Bitnami
# reads (global.postgresql.auth.secretKeys.adminPasswordKey).
existingSecret: "aqueduct-secrets"
secretKeys:
password: "POSTGRES_PASSWORD"Is bootstrapFromExternal necessary in aqueduct/staging.yaml? If not, can I delete it?
+) I'm guessing bootstrapFromExternal was only used the first time CNPG started to clone the old database and prevent data loss.
There was a problem hiding this comment.
Yes we can disable it but leave the config for posterity as documentation.
| tls: false | ||
| tlsSecretName: "" | ||
|
|
||
| postgresql: |
There was a problem hiding this comment.
Can I remove this block from aqueduct/staging.yaml as well?
postgresql:
enabled: false # Step 3 of Bitnami -> CNPG migration: stop Bitnami, app auto-derives CNPG host/creds. PVC is NOT deleted.
primary:
extraEnvVars:
- name: POSTGRESQL_MAX_CONNECTIONS
value: "300"
extendedConfiguration: |
shared_buffers = 6000MB
# Allow pg_basebackup replication connections from the CNPG pod (the
# default pg_hba.conf has no `host replication` rule, and the `all`
# database does not match the `replication` pseudo-database). Required for
# the side-by-side CNPG bootstrap in step 1 of the Bitnami -> CNPG migration.
pgHbaConfiguration: |-
local all all trust
host all all 0.0.0.0/0 md5
host all all ::/0 md5
host replication postgres 0.0.0.0/0 md5
host replication postgres ::/0 md5
persistence:
enabled: true
size: 10Gi
resources:
limits:
cpu: "2"
memory: "8Gi"
requests:
cpu: "2"
memory: "8Gi"There was a problem hiding this comment.
Yes this can be removed once it is merged.
There was a problem hiding this comment.
Can I open an issue so I don't forget it?
|
To me it looks good, but you could also ask Josef to have a look :) |
meffmadd
left a comment
meffmadd
left a comment
There was a problem hiding this comment.
Changes look reasonable but we should wait some time before merging this.
| tls: false | ||
| tlsSecretName: "" | ||
|
|
||
| postgresql: |
There was a problem hiding this comment.
Yes this can be removed once it is merged.
| # connections (wal_level >= replica, a pg_hba `replication` rule, and a user | ||
| # with REPLICATION privilege, e.g. the `postgres` superuser). Only takes effect | ||
| # on first creation (the Cluster must not yet exist). | ||
| bootstrapFromExternal: |
There was a problem hiding this comment.
Yes we can disable it but leave the config for posterity as documentation.
Just curious, what's blocking this PR from being merged? |
|
We should provide some deprecation period for other users as the charts would stop working if there is no CNPG operator installed on the cluster. |
3 participants
Bitnami's postgresql and redis charts are outdated and no longer maintained, so
they've been removed.
This removes all Bitnami and outdated code, updates the related comments, and deletes
the vendored .tgz files.