143: Replace OIDC-mapping settings functions with admin config snippets - #183
Merged
Merged
Conversation
JaeYeonLee0621
marked this pull request as draft
August 24, 2026 13:14
JaeYeonLee0621
marked this pull request as ready for review
August 25, 2026 10:35
JaeYeonLee0621
commented
Aug 25, 2026
| ADMIN_GROUP = os.getenv("ADMIN_GROUP", "") | ||
| ADMIN_SUPERUSER_EMAILS = [ | ||
| e.strip().lower() for e in os.getenv("ADMIN_SUPERUSER_EMAILS", "").split(",") if e.strip() | ||
| ] |
Contributor
Author
There was a problem hiding this comment.
📝
ADMIN_GROUP: is_staff + is_superuserADMIN_SUPERUSER_EMAILS: is_staff + is_superuser + access Snippet Admin
Contributor
There was a problem hiding this comment.
Looks like ADMIN_SUPERUSER_EMAILS is not documented anywhere though!
Contributor
Author
There was a problem hiding this comment.
Thanks!! I added the explanation in admin.md documents, this part Auto-admin via ADMIN_SUPERUSER_EMAILS
natkam
requested changes
Aug 26, 2026
natkam
left a comment
natkam
left a comment
Contributor
There was a problem hiding this comment.
Some nit-picks and minor improvement suggestions only. Overall this really looks great! 🚀
added 2 commits
August 27, 2026 11:59
JaeYeonLee0621
commented
Aug 27, 2026
| ADMIN_GROUP = os.getenv("ADMIN_GROUP", "") | ||
| ADMIN_SUPERUSER_EMAILS = [ | ||
| e.strip().lower() for e in os.getenv("ADMIN_SUPERUSER_EMAILS", "").split(",") if e.strip() | ||
| ] |
Contributor
Author
There was a problem hiding this comment.
Thanks!! I added the explanation in admin.md documents, this part Auto-admin via ADMIN_SUPERUSER_EMAILS
natkam
approved these changes
Aug 27, 2026
natkam
left a comment
natkam
left a comment
Contributor
There was a problem hiding this comment.
Awesome! Feel free to merge it whenever you have time :)
Contributor
Author
|
Thanks for the review! :) I'll merge it once Matthias checks it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADMIN_SUPERUSER_EMAILSsettingSnippetAdminis restricted to superusers whose email is onADMIN_SUPERUSER_EMAILSConfigSnippetclass in management/snippets.py