🔨 Fix - PDF 업로드 presigned url 처리

[GiHwan2]

Related issue 🛠

closed #796

어떤 변경사항이 있었나요?

• 🔨 Fix: Feature change or bug fix

CheckPoint ✅

PR이 다음 요구 사항을 충족하는지 확인하세요.

• PR 컨벤션에 맞게 작성했습니다. (필수)
• 코드가 정상적으로 동작합니다. (필수)
• 코드 리뷰어에게 리뷰를 요청했습니다. (필수)

Work Description ✏️

관리자가 PDF 파일을 업로드할 때 presigned url을 사용하여 클라이언트에서 직접 S3에 업로드할 수 있도록 수정했습니다.

주요 변경사항

• 새로운 API 추가: /v1/admins/orders/{orderId}/documents/pdf-presigned-url

  • 관리자가 PDF 업로드를 위한 presigned url을 요청할 수 있는 엔드포인트 추가
  • 요청: 문서 목록과 업로드할 PDF 정보
  • 응답: S3 presigned url 목록과 업로드 상태 추적을 위한 정보

• PDF 업로드 상태 조회 API 추가: /v1/admins/orders/{orderId}/pdf-upload-status

  • 관리자가 PDF 업로드 진행 상태를 실시간으로 확인할 수 있는 조회 API
  • EPdfUploadStatus enum을 통한 상태 관리 (IN_PROGRESS, WATERMARKING, COMPLETED, FAILED)

• 도메인 모델 개선:

  • DocumentService와 PdfService에서 presigned url 생성 및 관리 로직 구현

• S3 유틸리티 개선:

  • S3Util에 presigned url 생성 기능 추가
  • AWS 설정 최적화 및 보안 강화

Uncompleted Tasks 😅

N/A

To Reviewers 📢

• presigned url 생성 시 보안 정책이 올바르게 적용되었는지 확인해주세요
• PDF 업로드 상태 추적 로직이 예상대로 동작하는지 검토해주세요
• S3 권한 설정이 적절한지 확인해주세요

[coderabbitai]

Walkthrough

관리자용 PDF 업로드에 사전서명 URL(put) 흐름을 추가하고, 업로드 상태 조회 API를 도입했다. AWS 구성에 S3Presigner 빈을 등록하고 S3Util에 presign 생성 및 CloudFront 서명 키 로딩을 추가했다. 컨트롤러 엔드포인트와 DTO, 유스케이스/서비스, 업로드 상태 enum을 확장했다.

Changes

Cohort / File(s)	Change Summary
AWS 구성 & S3 유틸 확장 src/main/java/com/tookscan/tookscan/core/config/AwsConfig.java, src/main/java/com/tookscan/tookscan/core/utility/S3Util.java	S3Presigner 빈 추가. S3Util에 presigned PUT URL 생성 메서드와 PresignedUpload 추가, 생성자에 S3Presigner 주입. CloudFront PEM 개인키 로딩 헬퍼 도입 및 서명 로직 정리. S3 키 사용 일관화.
유스케이스/서비스: presign 업로드 .../order/application/usecase/UploadAdminDocumentsPdfWithPresignedUrlUseCase.java, .../order/application/service/UploadAdminDocumentsPdfWithPresignedUrlService.java	사전서명 URL 기반 업로드 유스케이스/서비스 신설. 파일명 검증, 중복 검사, Pdf 엔티티 생성/배치 저장, 15분 만료 presign 생성, 응답 매핑.
유스케이스/서비스: 업로드 상태 조회 .../order/application/usecase/ReadAdminPdfUploadStatusUseCase.java, .../order/application/service/ReadAdminPdfUploadStatusService.java	업로드 상태 단건 조회 유스케이스/서비스 추가. 리포지토리 조회 후 DTO 변환 반환.
컨트롤러 .../order/presentation/controller/command/OrderAdminCommandV1Controller.java, .../order/presentation/controller/query/OrderAdminQueryV1Controller.java	Presign 발급 POST /documents/{documentId}/pdfs 추가. 기존 멀티파트 업로드 경로를 /documents/{documentId}/pdfs/upload로 변경. 업로드 상태 조회 GET /orders/documents/pdfs/{pdfId}/upload-status 추가.
DTO .../presentation/dto/request/UploadAdminDocumentsPdfWithPresignedUrlRequestDto.java, .../presentation/dto/response/UploadAdminDocumentsPdfWithPresignedUrlResponseDto.java, .../presentation/dto/response/ReadAdminPdfUploadStatusResponseDto.java	요청 DTO(record)로 파일명 리스트 수신. 응답 DTO에 업로드 항목(Url, Headers 포함) 구조 추가. 상태 조회 DTO 추가(완료 시에만 관리자용 URL 포함).
도메인 타입 .../order/domain/type/EPdfUploadStatus.java	업로드 상태에 WATERMARKING 추가 및 fromString 매핑 확장.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Admin as Admin
  participant CmdCtrl as OrderAdminCommandV1Controller
  participant UseCase as UploadAdminDocumentsPdfWithPresignedUrlService
  participant Repo as PdfRepository
  participant S3U as S3Util
  participant Presigner as S3Presigner

  Admin->>CmdCtrl: POST /documents/{documentId}/pdfs (파일명 리스트)
  CmdCtrl->>UseCase: execute(documentId, requestDto)
  UseCase->>UseCase: 파일명 유효성/중복 검사
  UseCase->>Repo: Pdf 엔티티 생성(상태=IN_PROGRESS) 배치 저장
  loop 각 파일
    UseCase->>S3U: getPresignedPutUrlForPdf(document, storedFileName, originalName, 15m)
    S3U->>Presigner: Presign PUT(Object)
    Presigner-->>S3U: Presigned URL + Headers
    S3U-->>UseCase: URL, Headers
  end
  UseCase-->>CmdCtrl: 업로드 정보 리스트 응답
  CmdCtrl-->>Admin: 200 OK (pdfId, url, headers)

Loading

sequenceDiagram
  autonumber
  actor Admin as Admin
  participant QryCtrl as OrderAdminQueryV1Controller
  participant UC as ReadAdminPdfUploadStatusService
  participant Repo as PdfRepository

  Admin->>QryCtrl: GET /orders/documents/pdfs/{pdfId}/upload-status
  QryCtrl->>UC: execute(pdfId)
  UC->>Repo: findByIdOrElseThrow(pdfId)
  Repo-->>UC: Pdf
  UC-->>QryCtrl: ReadAdminPdfUploadStatusResponseDto
  QryCtrl-->>Admin: 200 OK (upload_status, pdf_url_for_admin?, name)

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

귀 쫑긋, 깡총! 새 링크가 솟았네—
바람 같은 presign, 15분 빛나네.
업로드 뛰고, 워터마킹 춤추고, 완주하면 링크 번쩍!
컨트롤러 두드려 띵동-상태도 확인 OK.
오늘도 당근 한 입, 배포는 깔끔하게. 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

💡 Knowledge Base configuration:

• Jira integration is disabled
• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ef8afc0 and b49ff0f.

📒 Files selected for processing (12)

• src/main/java/com/tookscan/tookscan/core/config/AwsConfig.java (2 hunks)
• src/main/java/com/tookscan/tookscan/core/utility/S3Util.java (5 hunks)
• src/main/java/com/tookscan/tookscan/order/application/service/ReadAdminPdfUploadStatusService.java (1 hunks)
• src/main/java/com/tookscan/tookscan/order/application/service/UploadAdminDocumentsPdfWithPresignedUrlService.java (1 hunks)
• src/main/java/com/tookscan/tookscan/order/application/usecase/ReadAdminPdfUploadStatusUseCase.java (1 hunks)
• src/main/java/com/tookscan/tookscan/order/application/usecase/UploadAdminDocumentsPdfWithPresignedUrlUseCase.java (1 hunks)
• src/main/java/com/tookscan/tookscan/order/domain/type/EPdfUploadStatus.java (2 hunks)
• src/main/java/com/tookscan/tookscan/order/presentation/controller/command/OrderAdminCommandV1Controller.java (4 hunks)
• src/main/java/com/tookscan/tookscan/order/presentation/controller/query/OrderAdminQueryV1Controller.java (4 hunks)
• src/main/java/com/tookscan/tookscan/order/presentation/dto/request/UploadAdminDocumentsPdfWithPresignedUrlRequestDto.java (1 hunks)
• src/main/java/com/tookscan/tookscan/order/presentation/dto/response/ReadAdminPdfUploadStatusResponseDto.java (1 hunks)
• src/main/java/com/tookscan/tookscan/order/presentation/dto/response/UploadAdminDocumentsPdfWithPresignedUrlResponseDto.java (1 hunks)

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.