🔨 Fix - 아이디 찾기 시, DeletedAt 고려하도록 변경

[dongkyeomjang]

Related issue 🛠

closed #794

어떤 변경사항이 있었나요?

• ✨ Feature: New feature
• 🔨 Fix: Feature change or bug fix
• 💻 CrossBrowsing: Browser compatibility
• 🌏 Deploy: Deploy
• 🎨 Design: Markup & styling
• 📃 Docs: Documentation writing and editing (README.md, etc.)
• ♻️ Refactor: Code refactoring
• ⚙️ Setting: Development environment setup
• ✅ Test: Test related (storybook, jest, etc.)

CheckPoint ✅

PR이 다음 요구 사항을 충족하는지 확인하세요.

• PR 컨벤션에 맞게 작성했습니다. (필수)
• 코드가 정상적으로 동작합니다. (필수)
• 코드 리뷰어에게 리뷰를 요청했습니다. (필수)

Work Description ✏️

작업 내용을 작성해주세요.

• 아이디 찾기 시, DeletedAt 고려하도록 변경

Uncompleted Tasks 😅

N/A

To Reviewers 📢

리뷰어가 알면 좋은 내용을 작성해주세요.

Summary by CodeRabbit

• 버그 수정
  • 휴대폰 번호와 이름으로 사용자 조회 시, 삭제된 계정이 결과에 포함되던 문제를 수정했습니다. 이제 삭제(비활성)된 계정은 조회 대상에서 제외되며, 인증·계정 찾기 과정에서 ‘계정을 찾을 수 없음’으로 안내됩니다. 이로써 데이터 정합성과 보안성이 향상되고, 잘못된 계정 매칭으로 인한 오탐이 감소합니다.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

User lookup now filters out soft-deleted accounts by changing the JPA method to include DeletedAt is null and updating the repository implementation to call the new method. The exception behavior remains unchanged.

Changes

Cohort / File(s)	Summary
Soft-delete filter in user lookup src/main/java/com/tookscan/tookscan/account/repository/mysql/UserJpaRepository.java, src/main/java/com/tookscan/tookscan/account/repository/impl/UserRepositoryImpl.java	Renamed derived query to findByPhoneNumberAndNameAndDeletedAtIsNull(...) and updated the impl to use it, adding a soft-delete (deletedAt IS NULL) predicate to user retrieval by phone and name.

Sequence Diagram(s)

sequenceDiagram
  participant Service
  participant UserRepositoryImpl
  participant UserJpaRepository
  participant DB

  Service->>UserRepositoryImpl: findByPhoneNumberAndNameOrElseThrow(phone, name)
  UserRepositoryImpl->>UserJpaRepository: findByPhoneNumberAndNameAndDeletedAtIsNull(phone, name)
  UserJpaRepository->>DB: SELECT ... WHERE phone=? AND name=? AND deleted_at IS NULL
  DB-->>UserJpaRepository: Optional<User>
  alt User found
    UserJpaRepository-->>UserRepositoryImpl: User
    UserRepositoryImpl-->>Service: User
  else Not found
    UserRepositoryImpl-->>Service: throw NOT_FOUND_ACCOUNT
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

토끼는 깡총, 데이터 숲을 뛰네
삭제 표식 null인지 살포시 살피네
이름과 번호, 맞다면 OK!
지워진 발자국이면 그대로 패스해
깡총깡총, 깔끔한 조회에 귀가 춤추네 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

💡 Knowledge Base configuration:

• Jira integration is disabled
• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d456149 and ff7d3a8.

📒 Files selected for processing (2)

• src/main/java/com/tookscan/tookscan/account/repository/impl/UserRepositoryImpl.java (1 hunks)
• src/main/java/com/tookscan/tookscan/account/repository/mysql/UserJpaRepository.java (1 hunks)

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.