🔨 Fix - 쿠폰 조회 NullPointException 해결

[dongkyeomjang]

Related issue 🛠

closed #792

어떤 변경사항이 있었나요?

• ✨ Feature: New feature
• 🔨 Fix: Feature change or bug fix
• 💻 CrossBrowsing: Browser compatibility
• 🌏 Deploy: Deploy
• 🎨 Design: Markup & styling
• 📃 Docs: Documentation writing and editing (README.md, etc.)
• ♻️ Refactor: Code refactoring
• ⚙️ Setting: Development environment setup
• ✅ Test: Test related (storybook, jest, etc.)

CheckPoint ✅

PR이 다음 요구 사항을 충족하는지 확인하세요.

• PR 컨벤션에 맞게 작성했습니다. (필수)
• 코드가 정상적으로 동작합니다. (필수)
• 코드 리뷰어에게 리뷰를 요청했습니다. (필수)

Work Description ✏️

작업 내용을 작성해주세요.
-쿠폰 조회 NullPointException 해결

Uncompleted Tasks 😅

N/A

To Reviewers 📢

리뷰어가 알면 좋은 내용을 작성해주세요.

Summary by CodeRabbit

• 버그 수정
  • 최대 사용 횟수가 미설정(무제한)인 발급 쿠폰 조회 시 발생하던 오류를 방지하여 화면 비정상 종료를 해소했습니다.
  • 최대 사용 횟수가 없는 쿠폰의 사용 여부가 잘못 표시되던 문제를 수정했습니다.
  • 사용/미사용 상태 계산 로직을 개선해 데이터 표시 정확도를 높였습니다.
  • 관리자의 발급 쿠폰 현황 화면의 안정성과 일관성을 향상했습니다.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

IssuedCoupon의 사용 여부 계산 로직에 maxUsedCount에 대한 null 체크를 추가하여 NPE를 방지하고, maxUsedCount가 null이면 isUsed가 false가 되도록 변경했다. 다른 필드 매핑과 정렬 로직은 변경 없다.

Changes

Cohort / File(s)	Summary of Changes
DTO 변환 로직 수정 src/main/java/com/tookscan/tookscan/order/presentation/dto/response/ReadAdminIssuedCouponOverviewResponseDto.java	isUsed 계산 시 issuedCoupon.getMaxUsedCount() != null && issuedCoupon.getUsedCount() >= issuedCoupon.getMaxUsedCount()로 수정하여 null 안전성 확보. 퍼블릭 시그니처 변경 없음.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

당근 한 입, 코드 한 줄 톡톡톡 🥕
쿠폰의 한계, null이면 살짝 멈칫—OK!
넘치면 사용, 비어있음은 그대로
예외는 굿바이, 로직은 스무스대로
토끼는 박수 짝짝, 릴리즈는 폴짝!

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Free

💡 Knowledge Base configuration:

• Jira integration is disabled
• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f64eb3c and ddc6657.

📒 Files selected for processing (1)

• src/main/java/com/tookscan/tookscan/order/presentation/dto/response/ReadAdminIssuedCouponOverviewResponseDto.java (1 hunks)

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.