Skip to content

๐Ÿ”จ Fix - ์˜ˆ์ƒ๊ฐ€๊ฒฉ ์กฐํšŒ์—์„œ useCoupon ๋ฉ”์†Œ๋“œ ์‚ญ์ œ#791

Merged
dongkyeomjang merged 1 commit into
devfrom
Fix/#790
Aug 19, 2025
Merged

๐Ÿ”จ Fix - ์˜ˆ์ƒ๊ฐ€๊ฒฉ ์กฐํšŒ์—์„œ useCoupon ๋ฉ”์†Œ๋“œ ์‚ญ์ œ#791
dongkyeomjang merged 1 commit into
devfrom
Fix/#790

Conversation

@dongkyeomjang

@dongkyeomjang dongkyeomjang commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

Related issue ๐Ÿ› 

closed #790

์–ด๋–ค ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์žˆ์—ˆ๋‚˜์š”?

  • โœจ Feature: New feature
  • ๐Ÿ”จ Fix: Feature change or bug fix
  • ๐Ÿ’ป CrossBrowsing: Browser compatibility
  • ๐ŸŒ Deploy: Deploy
  • ๐ŸŽจ Design: Markup & styling
  • ๐Ÿ“ƒ Docs: Documentation writing and editing (README.md, etc.)
  • โ™ป๏ธ Refactor: Code refactoring
  • โš™๏ธ Setting: Development environment setup
  • โœ… Test: Test related (storybook, jest, etc.)

CheckPoint โœ…

PR์ด ๋‹ค์Œ ์š”๊ตฌ ์‚ฌํ•ญ์„ ์ถฉ์กฑํ•˜๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”.

  • PR ์ปจ๋ฒค์…˜์— ๋งž๊ฒŒ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค. (ํ•„์ˆ˜)
  • ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•ฉ๋‹ˆ๋‹ค. (ํ•„์ˆ˜)
  • ์ฝ”๋“œ ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ๋ฆฌ๋ทฐ๋ฅผ ์š”์ฒญํ–ˆ์Šต๋‹ˆ๋‹ค. (ํ•„์ˆ˜)

Work Description โœ๏ธ

  • ์˜ˆ์ƒ๊ฐ€๊ฒฉ ์กฐํšŒ์—์„œ useCoupon ๋ฉ”์†Œ๋“œ ์‚ญ์ œ

Uncompleted Tasks ๐Ÿ˜…

N/A

To Reviewers ๐Ÿ“ข

๋ฆฌ๋ทฐ์–ด๊ฐ€ ์•Œ๋ฉด ์ข‹์€ ๋‚ด์šฉ์„ ์ž‘์„ฑํ•ด์ฃผ์„ธ์š”.

Summary by CodeRabbit

  • ๋ฒ„๊ทธ ์ˆ˜์ •
    • ์ฟ ํฐ ์ ์šฉ ์ฒ˜๋ฆฌ ๋ฐฉ์‹์„ ์กฐ์ •ํ•˜์—ฌ ์ฃผ๋ฌธ์— ์—ฐ๊ฒฐ๋œ ์‚ฌ์šฉ ์ฟ ํฐ ๊ธฐ๋ก์„ ์ผ๊ด€๋˜๊ฒŒ ์ƒ์„ฑํ•ฉ๋‹ˆ๋‹ค. ์ด์— ๋”ฐ๋ผ ์ฃผ๋ฌธ ์ƒ์„ธ์˜ ์ฟ ํฐ ์ ์šฉ ๋‚ด์—ญ๊ณผ ๊ธˆ์•ก ๋ฐ˜์˜์ด ๋” ์•ˆ์ •์ ์œผ๋กœ ํ‘œ์‹œ๋ฉ๋‹ˆ๋‹ค.
    • ์ผ๋ถ€ ์ƒํ™ฉ์—์„œ ์ฟ ํฐ์ด ์‹ค์ œ ์‚ฌ์šฉ๊ณผ ๋‹ค๋ฅด๊ฒŒ ์ƒํƒœ๊ฐ€ ํ‘œ์‹œ๋  ์ˆ˜ ์žˆ๋˜ ๋ฌธ์ œ๋ฅผ ์™„ํ™”ํ•˜์—ฌ, ์ฟ ํฐ ์‚ฌ์šฉ ์ด๋ ฅ๊ณผ ์ฃผ๋ฌธ ๊ธฐ๋ก ๊ฐ„ ๋ถˆ์ผ์น˜๋ฅผ ์ค„์˜€์Šต๋‹ˆ๋‹ค.

@dongkyeomjang dongkyeomjang self-assigned this Aug 19, 2025
@dongkyeomjang dongkyeomjang added the ๐Ÿ”จ Fix ๊ธฐ๋Šฅ ๋ณ€๊ฒฝ or ๋ฒ„๊ทธ ํ•ด๊ฒฐ label Aug 19, 2025
@coderabbitai

coderabbitai Bot commented Aug 19, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

EstimateUserOrderPriceService ์ˆ˜์ •: ์ฟ ํฐ ์ฒ˜๋ฆฌ ๋กœ์ง์—์„œ IssuedCoupon.useCoupon() ํ˜ธ์ถœ์„ ์ œ๊ฑฐํ•˜๊ณ , IssuedCoupon๊ณผ ์ฃผ๋ฌธ์„ ์—ฐ๊ฒฐํ•˜๋Š” UsedCoupon๋งŒ ์ƒ์„ฑํ•˜๋„๋ก ๋ณ€๊ฒฝ. ์ฃผ์„๋„ ์ฟ ํฐ ์ ์šฉ์—์„œ ์ƒ์„ฑ์œผ๋กœ ์ˆ˜์ •. order.updateUsedCoupon ๋“ฑ ๋‚˜๋จธ์ง€ ํ๋ฆ„์€ ์œ ์ง€.

Changes

Cohort / File(s) Summary
Order Price Estimation โ€“ Coupon Handling
src/main/java/com/tookscan/tookscan/order/application/service/EstimateUserOrderPriceService.java
์ฟ ํฐ ์ฒ˜๋ฆฌ ์‹œ IssuedCoupon.useCoupon() ํ˜ธ์ถœ ์ œ๊ฑฐ. IssuedCoupon๊ณผ Order๋ฅผ ์ฐธ์กฐํ•˜๋Š” UsedCoupon๋งŒ ์ƒ์„ฑํ•˜๊ณ , ์ดํ›„ order.updateUsedCoupon ํ˜ธ์ถœ ํ๋ฆ„์€ ๋™์ผ. ๊ด€๋ จ ์ฃผ์„ ํ…์ŠคํŠธ๋ฅผ โ€œ์ ์šฉโ€์—์„œ โ€œ์ƒ์„ฑโ€์œผ๋กœ ๋ณ€๊ฒฝ.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Service as EstimateUserOrderPriceService
  participant Issued as IssuedCoupon
  participant Used as UsedCouponRepo
  participant Order as Order

  rect rgba(200,220,255,0.25)
  note over Service: ์ด์ „(Old) ํ๋ฆ„
  User->>Service: ๊ฐ€๊ฒฉ ๊ฒฌ์  ์š”์ฒญ(์ฟ ํฐ ํฌํ•จ)
  Service->>Issued: ์กฐํšŒ ๋ฐ ๊ฒ€์ฆ
  Service->>Issued: useCoupon() ํ˜ธ์ถœ
  Service->>Used: UsedCoupon ์ƒ์„ฑ/์ €์žฅ
  Service->>Order: updateUsedCoupon(UsedCoupon)
  Service-->>User: ๊ฒฐ๊ณผ ๋ฐ˜ํ™˜
  end

  rect rgba(200,255,200,0.25)
  note over Service: ๋ณ€๊ฒฝ(New) ํ๋ฆ„
  User->>Service: ๊ฐ€๊ฒฉ ๊ฒฌ์  ์š”์ฒญ(์ฟ ํฐ ํฌํ•จ)
  Service->>Issued: ์กฐํšŒ ๋ฐ ๊ฒ€์ฆ
  note right of Service: useCoupon() ํ˜ธ์ถœ ์ œ๊ฑฐ
  Service->>Used: UsedCoupon ์ƒ์„ฑ/์ €์žฅ (Issued, Order ์—ฐ๊ณ„)
  Service->>Order: updateUsedCoupon(UsedCoupon)
  Service-->>User: ๊ฒฐ๊ณผ ๋ฐ˜ํ™˜
  end
Loading

Estimated code review effort

๐ŸŽฏ 2 (Simple) | โฑ๏ธ ~10 minutes

Poem

๋‹น๊ทผ ๊นƒํ„ธ ๊ท€๋ฅผ ํŽ„๋Ÿญ์ด๋ฉฐ ์ถค์„ ์ถ”๋„ค,
์ฟ ํฐ์€ ์ฐ์—ˆ์ง€๋งŒ, ๋„์žฅ์€ ์•„๊ปด๋’€์ง€ ๐Ÿฅ•
์‚ฌ์šฉ ํ‘œ์‹์€ ์ž ์‹œ ๋ฉˆ์ถ”๊ณ , ์—ฐ๊ฒฐ๋งŒ ์‚ด์งโ€”
์ฃผ๋ฌธ๊ณผ ์ฟ ํฐ์ด ๋‚˜๋ž€ํžˆ ํ† ๊ธ€ํƒ!
๋ฐคํ•˜๋Š˜ ๋ณ„์ฒ˜๋Ÿผ ๋กœ์ง์€ ๋ฐ˜์ง, ํ…Œ์ŠคํŠธ๋„ ์ฝฉ๋‹ฅ์ฝฉ๋‹ฅ.

Tip

๐Ÿ”Œ Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


๐Ÿ“œ Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

๐Ÿ’ก Knowledge Base configuration:

  • Jira integration is disabled
  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 9aacdfe and d6e2031.

๐Ÿ“’ Files selected for processing (1)
  • src/main/java/com/tookscan/tookscan/order/application/service/EstimateUserOrderPriceService.java (1 hunks)

Note

๐ŸŽ Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

๐Ÿชง Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dongkyeomjang dongkyeomjang merged commit f64eb3c into dev Aug 19, 2025
1 of 2 checks passed
@dongkyeomjang dongkyeomjang deleted the Fix/#790 branch August 19, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

๐Ÿ”จ Fix ๊ธฐ๋Šฅ ๋ณ€๊ฒฝ or ๋ฒ„๊ทธ ํ•ด๊ฒฐ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

๐Ÿ”จ Fix - ์˜ˆ์ƒ๊ฐ€๊ฒฉ ์กฐํšŒ์—์„œ useCoupon ๋ฉ”์†Œ๋“œ ์‚ญ์ œ

1 participant