add support for streaming ANTARES alerts - #44
Merged
Conversation
github-project-automation
Bot
moved this from Needs Review
to Merged (to dev)
in TOM Toolkit
jchate6
reviewed
Feb 11, 2026
jchate6
left a comment
jchate6
left a comment
Contributor
There was a problem hiding this comment.
I don't think we should require antares_client as a dependency.
Also, I don't think these changes make much sense without TOMToolkit/tom_antares#81.
I think what we should do here is move antares_client or maybe tom_antares to a dependency group in pyproject.toml and add a section in the README about how to install this app for Tom Antares.
Member
Agreed. This is address in #49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for streaming ANTARES alerts over Kafka. It's essentially a thin wrapper around the functionality in the
antares-clientpackage.