DRAFT: first attempt at linking obs table rows to data archives - #26
Draft
crpellegrino wants to merge 2 commits into
Draft
DRAFT: first attempt at linking obs table rows to data archives#26crpellegrino wants to merge 2 commits into
crpellegrino wants to merge 2 commits into
Conversation
Collaborator
|
Just tested this and it works for the HST observations! This is sick |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a DRAFT PR adding functionality to link observation table rows to their associated data archives. This is done by adding an "External Observation ID" column to the table which renders the ACROSS
external_observation_idas a URL linking to an external data archive, bespoke for each observatory. Observatories that have resolvable data archives include HST, JWST, Chandra, IXPE, NICER, NuSTAR, Swift, XMM-Newton, and XRISM.Right now the
across-toolsfunctionality to resolve the archive links is on a development branch, therefore I've updated the install to point there. It's subject to change quite a bit in the short term, but I wanted to put this PR up as a proof of concept of this functionality and to get any feedback.To test this, checkout this branch, and then open any target page in your local TOM. You should see this extra
external_observation_IDcolumn on the ACROSS observations table. Try out the links and make sure they work.