dd homework - #3
Open
shankshannon wants to merge 1 commit into
Open
Conversation
sol87
approved these changes
Dec 19, 2018
sol87
left a comment
sol87
left a comment
There was a problem hiding this comment.
我没有测试它的运行情况，但纯从代码质量上看非常棒，很工整。
Good job!
| #创建gizimao | ||
| #创建一个group | ||
| #在group中创建3个text，设置text内容 | ||
| #连接group的输入输出 |
| w['create_directories'].setValue('True') | ||
| nuke.execute('Write1',100,400,1) | ||
|
|
||
|
|
| #创建一个group | ||
| #在group中创建3个text，设置text内容 | ||
| #连接group的输入输出 | ||
| g = nuke.createNode('Group') |
There was a problem hiding this comment.
单字母的变量名不可取，尤其是这种全局的写法。我觉得你可以尝试把这个代码写成几个函数。
|
I just approved your work, please feel free to edit your code or merge the pull request directly. |
haogeek
reviewed
Jan 5, 2019
| w['meta_codec'].setValue('mp4v') | ||
| w['file'].setValue('D:/TDclass/pipeline/aaa/aaa.mov') | ||
| w['create_directories'].setValue('True') | ||
| nuke.execute('Write1',100,400,1) |
haogeek
reviewed
Jan 5, 2019
| w['create_directories'].setValue('True') | ||
| nuke.execute('Write1',100,400,1) | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
建议是用cmd参数（即sys.argv）读入原素材路径和mov目标路径，而不是写死在代码里，我们需要的是一个加水印转码工具，而不是一个一次性的脚本
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first Nuke Python script