Skip to content

Delay voice first-join notice until no mod present - #211

Open
Rinzii wants to merge 3 commits into
TCCPP:mainfrom
Rinzii:patch-new-join-notif
Open

Delay voice first-join notice until no mod present#211
Rinzii wants to merge 3 commits into
TCCPP:mainfrom
Rinzii:patch-new-join-notif

Conversation

@Rinzii

@Rinzii Rinzii commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Also applied planned changes earlier discussed with @jeremy-rifkin and @xLuxy to make it so that we DM users first before falling back to using the normal local channel to tell the user if a DM fails.

Comment thread src/modules/tccpp/components/voice-first-join-notice.ts
@jeremy-rifkin

Copy link
Copy Markdown
Member

I don't think I see the motivation for doing this only when a mod isn't present. If this message isn't sent, the user is probably going to ping mods asking and then someone is going to have to explain it to them, which is the exact problem this message is trying to solve.

@Rinzii

Rinzii commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

I don't think I see the motivation for doing this only when a mod isn't present. If this message isn't sent, the user is probably going to ping mods asking and then someone is going to have to explain it to them, which is the exact problem this message is trying to solve.

iirc the motivation was discussed somewhere but idr where, but the general idea was many times when a VC mod is in a channel a user joins, gets the message, and is either confused they can talk, miss the message because they can talk, or some other mixture of that. When this PR was made it was a very frequent occurrence and still happens now as there is no easy way to tell if a VC mod is present or not.

@Rinzii
Rinzii requested a review from jeremy-rifkin July 20, 2026 18:40
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants