Skip to content

Python3 support#26

Open
Eeems wants to merge 5 commits into
TC01:masterfrom
Eeems:master
Open

Python3 support#26
Eeems wants to merge 5 commits into
TC01:masterfrom
Eeems:master

Conversation

@Eeems

@Eeems Eeems commented Jun 24, 2018

Copy link
Copy Markdown
Collaborator

Fix #24

@Eeems

Eeems commented Jun 24, 2018

Copy link
Copy Markdown
Collaborator Author

Best viewed without whitespace changes

@TC01

TC01 commented Jul 5, 2018

Copy link
Copy Markdown
Owner

Hey, thanks for working on this!

I have been meaning to rewrite calcpkg for a while (the index searching code is terrible, for instance), so I've put off trying to port it to Python 3. But it is probably worth porting the current implementation anyway!

I'm not so keen on the PEP8 formatting changes, but I don't really mind, and it's a minor price to pay for a working python 3 implementation.

I will look through this and make sure nothing is horribly broken, and then merge into master.

@Eeems

Eeems commented Jul 5, 2018

Copy link
Copy Markdown
Collaborator Author

Awesome thanks :)

What PEP8 rules do you not like? I have to use PEP8 at work, and thus my editor is setup to automatically enforce them. I could mess around with disabling specific rules for just this projects if you'd prefer.

@TC01

TC01 commented Jul 5, 2018

Copy link
Copy Markdown
Owner

What PEP8 rules do you not like? I have to use PEP8 at work, and thus my editor is setup to automatically enforce them. I could mess around with disabling specific rules for just this projects if you'd prefer.

The main one is the 80 characters per line limitation-- I think that 120 is probably more reasonable these days. I also don't really believe text should be wrapped if it goes a "little" over (for example, a string that is a few extra characters long) just to meet an arbitrary limit.

I don't really mind when it's done, I just don't stick to it myself.

@Eeems

Eeems commented Jul 5, 2018

Copy link
Copy Markdown
Collaborator Author

I'm also of the opinion that line limits based on old printers are silly. It looks like I can setup per-project configuration (http://damnwidget.github.io/anaconda/anaconda_settings/), so I'll update my line length limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants