Repository navigation
Fix preview downloads that never saved (0.1.6-1) - #13
Merged
Merged
Conversation
The host server gives the sandboxed browser a /tmp path for downloads, but the sandbox has its own /tmp, so files never reached the server. Share /tmp so both sides see them, and release as 0.1.6-1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downloads started in a preview tab never saved in the Flatpak. They finished, then got stranded in the sandbox and disappeared when the app closed.
The host server tells the sandboxed browser to save under
/tmp, but the sandbox has its own private/tmp, so the server never saw the file. Sharing/tmpwith the host lets upstream's normal download flow work.Tested on the installed 0.1.6 with the same permission as a local override: the file reached the server, and the Download button saved it to
~/Downloads.