Conversation
- Add DataList plugin support. - Require description. - Edit "Resources Title" verbose name. - Update To Do list. - Rebuild migrations. - Rebuild specifications using table.
Enable the link by adding missing context variables. TODO: Prevent duplicate entires in "Internal Link".
Do not let "Internal Link" have duplicate options.
For System Monitor, Image / Picture, and DataList: - Limit System Specs child plugins to these. - Style these in System Monitor layout. - Load System Monitor styles via new `app.*` stylesheet.
This prepares for the rename that occurs in task/GH-89.
Closed
This was referenced Aug 30, 2021
iamthatian
approved these changes
Sep 13, 2021
Contributor
iamthatian
left a comment
There was a problem hiding this comment.
Everything works well! Will approve.
One question I had was if there should be a limit to how long the description should be?
It seemed to break the style if the description gets too long.
Co-authored-by: Ian Park <contact@duckonomy.com>
Member
Author
|
@duckonomy Changes made.
Yes. Excellent catch. I've set 500, which is: Reasoning
Extra ThoughtsThe problem with text limits is that on some window widths the text may be "too much" and on some window widths the text is not enough. But some limit should exist to prevent someone from entering the text of a novel, or relying solely on "Description" when they should use a Data List table. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To Do (Done)
Overview
Create System Specs plugin.
Issues
Screenshots
Form
Render
TACC: Shared UI - Constants - Breakpoints
Structure
The "Style" elements are a necessary evil until I create Section plugin (GH-91).
Testing
If no environment, then prepare to test CMS changes.
In CMS container, run
python3 manage.py migrate.On CMS website, logged in as admin, create a new "Frontera System" page.
On the new page:
(optional) Choose "Standard" template (to get Breadcrumbs).
(optional) Add two "Generic" > "Style" plugins (to create Sections) with:
Details
---------sectiono-section, o-section--style-light(required) Add "TACC Site" > "System Specs" plugin (optionally within "Style" plugin).
(optional) Add "TACC Site" > "Callout" plugin with any content (optionally within "Style" plugin).
Ensure the following behavior:
Required Behavior
Notes
This plugin will be used first on [Frontera System page], and then on TACC system pages (e.g. stampede2, longhorn, stockyard).