Repository navigation
feat(ptc): teach the sandbox tier through user-message guidance - #1035
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #963
Closes #929
What was wrong
Two independent defects in the OPS-PTC batching guidance:
danger-full-accesssession it still told the model to sendsandbox_permissions/justification, a request the host rejects before any line of the program runs ([BUG] PTC:run_code 注入的 sandbox_permissions 被误填非法值时,整个程序被拒且错误信息不可操作 #963).run_coderesult asadditionalContexts. That inbox is same-step only and never logged, so the model could readthe guidance as tool output instead of the instruction that governs the task ([BUG] batchingGuidance step-tail message re-enters the conversation as fresh user input (self-sustaining loop) #929).
The change
GuidanceSurfacegainssandbox; the shippedprompts/batching-guidance.mdgains a## Sandbox permissionssection;renderBatchingGuidancekeeps only the tier the host reports, pins the closed vocabulary(
workspace-write,danger-full-access), andBATCHING_GUIDANCE_REVISIONbumps to 8.on the accepted pre-step batch, with no plugin envelope.
taughtlatches only after the hostcommits that exact message, so a rejected or cancelled batch teaches again.
BATCHING_GUIDANCE_LESSON_IDand the tool-result delivery path are removed.CHANGELOGentries are kept; the renamedprompt-user-teachingsuiteabsorbs the sandbox assertions; the cost-ledger suite recognises the rendered lesson by its
heading instead of byte equality with the shipped file.
main07d8233e. Its README rewrite dropped thedocs-factscountline ("15 file/document tools"), which the docs gate asserts; the line is restored in
README.mdso the gate keeps its fact.Validation
Reverting the sandbox renderer turns the
batching-guidancesandbox checks red; reverting thedelivery path turns the
prompt-user-teachingchecks red.CI requiredpassed on every blockingjob:
validate(linux-x64, darwin-x64, darwin-arm64, win32-x64),node-floor,rust-lint,workflow-lint,source-sizeandtools-trial.Environment
c70633da, synced with07d8233e