Repository navigation
Conversation
… trajectories The first-round lesson enters message history, so it must not repeat itself. Remove the anti-pattern section and the trailing prose that restated Step 1's dependency split; restore load-only-missing and recheck-after-a-mode-change as core rules; keep the four executable trajectories byte-identical. Bump BATCHING_GUIDANCE_REVISION 6 -> 7 and pin the measured trimmed size in the guidance suite.
Collaborator
Author
|
Superseded by #1033:18 张 OPS-PTC 卡的实现已随统一 PR 合入 main(本 PR 的提交已在 main 中),保留为评审记录。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #982
What was wrong
The first-round
batchingGuidancelesson enters message history, so every repeated sentence is re-read on each request. The shipped text restated Step 1's dependency split after Trajectories 2 and 3, restated the batching lesson a third time after Trajectory 4, and carried a two-example anti-pattern section that taught the same batching rule a model had already seen three times. Meanwhile "load only missing APIs" and "recheck the SDK after a mode change" lived only as Step 3 clauses, not as the rules they are. Baseline measured withBuffer.byteLength(text, "utf8"): body 8645 B, delivery source prefix 84 B (unchanged, counted separately).The change
Trim table (per section;
prompts/batching-guidance.mdon card/p1-lineage @ a277691):**Load only missing APIs****Recheck the SDK after a mode change**SDK loadinganchor line intact for the loader-less renderingexpectedRevisionflow untouchednextOffsetsentence; drop the repeatshapenotice and Trajectory 1's live example; the human-facing description stays in both configuration referencesMeasured result: body 8645 B → 7538 B (−1107 B, −12.8%); the 84 B delivery prefix is unchanged.
BATCHING_GUIDANCE_REVISION6 → 7. The full-pool + loader scope still receives the file byte for byte (unchanged renderer path, asserted by the existing suite), so the P1 publication contract is preserved.test/batching-guidance.test.mjsis outside the files #982 lists; it is where the revision pin lives, so the red/green assertions land there. Docs updated in the same PR:docs/CHANGELOG.md## [Unreleased](EN+ZH) and both configuration references (EN+ZH). Deliberately not done: no Outcome/schema changes for bytes, no rebase onto #938/#999 lineages (merge order is an integration-stage decision), and #869's additive "one session, one scope" content is untouched — coordination comment posted on #869.Validation
Red first, then green. Reverting
prompts/batching-guidance.mdturns the trim/rules/size checks red; reverting the revision bump turns the identity check red.pull_request事件触发的CI requiredrun,且已把该 run 的 URL 贴到下方代码块 — 仓库约定不在每个 PR 上跑 CI,聚合 run 留到集成/构建阶段统一执行npm run verify的实际输出(或DSH_OPS_REQUIRE_RUNTIME=1 npm run verify) — 未跑完整 gate,按 [OPS-PTC P2] 精简首轮教学并保留四条可执行示例 #982 定向验证入口只跑两个目标套件,读数如上docs/CHANGELOG.md的## [Unreleased]已加条目(EN+ZH)package.json的版本与optionalDependenciesEnvironment
Linux x64, Node 22 (repo toolchain), based on
origin/card/p1-lineage@ a277691 (PR #930 head); claim posted on #982 with main@58f6e28. Worker: stagedruntime/linux-x64/dsh-ops-worker(sha256 2b5f988d…).