Repository navigation
fix(windows): preserve restorable extended attributes and diagnose ASAR member paths (#874, #836) - #1006
Closed
Nicholas023 wants to merge 3 commits into
Closed
fix(windows): preserve restorable extended attributes and diagnose ASAR member paths (#874, #836)#1006Nicholas023 wants to merge 3 commits into
Nicholas023 wants to merge 3 commits into
Conversation
This was referenced Nov 20, 2026
Thatgfsj
added a commit
that referenced
this pull request
Nov 20, 2026
- cargo fmt: the three merged native branches had unformatted code (rust-lint red on #1005, #1006 and #1023); run rustfmt over the workspace. - file_path_tests: pin the canonical temp path before walking, so macOS's /var -> /private/var symlink no longer turns the asar-member expectation into PATH_RESTRICTED (darwin legs were red on #1006). - drop the dead imports/comments left by the superseded P7 step-tail provider (prompt-injection, resident-switch, ptc.ts). Refs #1032, #1033.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #874
Refs #836
What was wrong
METADATA_UNSUPPORTED.read, paths inside an Electron.asararchive failed with a generic no-follow/path-restriction error, with no actionable diagnosis.The change
native/windows-metadata: bounded EA capture, restore and byte verification for every user-restorable extended attribute.$KERNEL.*names are reported individually inmetadataWarningsbecause user mode cannot recreate them; every other capture/restore/verification failure still aborts publication.native/crates/ops-files: an.asarmember component is diagnosed asARCHIVE_MEMBER_UNSUPPORTED— Electron presents the archive as a directory only inside its patched in-process filesystem, so the standalone worker cannot read archive members. This is an actionable diagnostic, not a virtual-filesystem fallback.Local validation:
file-asar-path2/2,file-operationsgreen,cargo test --workspace --lockedgreen,check:size824 files all ≤1000 lines.Validation
The gate lines above were produced on the local integration head
b21274dd(all slices merged) with the pinned local fixtures:DSH_OPS_TEST_BASH= a verified pinned MSYS bash (sha256 6cc575e9…),DSH_OPS_NIUBASH_ARCHIVE= the shipped frozen archive. Each PR branch was also built and its own suites were run before push; the counts below are from those runs.CI required run: the pull_request event for this PR triggers
ci.yml; paste the aggregateCI requiredrun URL here once it finishes.Environment
maincommit58f6e281(origin/main at submission)npm ci --ignore-scripts --offline,npm run build,npm run stage:niubash -- --offline --archive <frozen archive>)