Repository navigation
fix(shells): reconcile Bash publication across session lifecycle events (#579, #842, #873, #928, #750) - #1004
Closed
Nicholas023 wants to merge 4 commits into
Closed
Nicholas023 wants to merge 4 commits into
Nicholas023 wants to merge 4 commits into
Conversation
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #579, #842, #873, #928
Refs #750
What was wrong
already registeredwarnings and aCannot read properties of undefined ('catch')listener error.ops_bashuntil an unrelated asynchronous reconcile happened to arrive.selectedDefault: ops-ptcin the profile; new sessions failed withagent-preset/not-found.dsh-win-pwsh7as undetected. The current source path already answers correctly in this host; the regression test guards that contract (no behavior fix is claimed here).The change
src/session-shells.ts: deduplicate overlapping row ownership; queued publications carry their identity and settle per generation; one failure per generation is reported once;turn/startre-asserts the current authority; disposal clears pending publications.src/presets/ops-ptc/register.ts: the unload lease captures the live settings service and restores the host's configured default only when the live default still namesops-ptc; any other preset is never rewritten, and a missing/rejecting settings service reports the leftover instead of guessing.session-idempotent-reconcile4/4,preset-default-leftover4/4,client-settings-plugin-manager1/1;preset-registration23/23 andshells-session6/6 stay green;check:sizegreen.Validation
The gate lines above were produced on the local integration head
b21274dd(all slices merged) with the pinned local fixtures:DSH_OPS_TEST_BASH= a verified pinned MSYS bash (sha256 6cc575e9…),DSH_OPS_NIUBASH_ARCHIVE= the shipped frozen archive. Each PR branch was also built and its own suites were run before push; the counts below are from those runs.CI required run: the pull_request event for this PR triggers
ci.yml; paste the aggregateCI requiredrun URL here once it finishes.Environment
maincommit58f6e281(origin/main at submission)npm ci --ignore-scripts --offline,npm run build,npm run stage:niubash -- --offline --archive <frozen archive>)