Repository navigation
Reassess cleared messages instead of caching NOT_SPAM - #558
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated messages could inherit an earlier NOT_SPAM verdict even after cross-chat history revealed a campaign. Text triage now neither saves nor reuses NOT_SPAM, including existing rows and sender-scoped mode. SPAM and SKIP retain their cache scopes and TTLs; in-flight coalescing is limited to the same chat, message ID, and text.
Black-box regressions cover a NOT_SPAM → NOT_SPAM → SPAM sequence with updated history and deletion, existing clearances, concurrent copies, and global-cache-disabled mode. The four regressions run against the original implementation failed as expected.
Validation: all 320 Vahter integration tests, all 133 Vahter unit tests, and the mandatory comment gate pass locally.
Tradeoff: repeated cleared messages and concurrent uncached copies make additional LLM calls.