Repository navigation
Fix checked native barcode crop bounds - #540
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Horizontal barcode crops retained the image's row stride but supplied a span shorter than ZXingCpp's checked ImageView requires. Valid images therefore threw an out-of-bounds exception and prematurely abandoned the remaining native crops.
Supply the full required stride and add one trailing row of managed buffer padding so bottom-edge crops also remain within bounds. This retains bounded spans and scoped pinning, with no unsafe code or per-crop pixel copies. Extract the native reader so behavioral regression tests can observe failures otherwise hidden by managed fallback.
Validation:
Coupon build and deploy tests use Ubuntu 24.04 ARM, matching the production image’s Noble base. Ubuntu 22.04 cannot load the packaged native library because it requires GLIBC_2.38; direct reader regressions exposed this previously hidden fallback. Other bots retain their existing runner default.