Repository navigation
CI: remove Retry Probe fixture; fix canary dry_run flag that was always live - #490
Merged
Merged
Conversation
…ys live The temporary _retry-probe.yml from #489 has done its job (see #489 comments): attempt 1 killed by timeout-minutes, Agent Retry fired within 10 s and called rerun-failed-jobs, attempt 2 re-ran only the dead leg, the completion of attempt 2 was ignored by the run_attempt guard, and in timeout-both mode exactly one retry happened (no attempt 3). Canary: `inputs.dry_run == 'true'` compares a boolean input to a string; GitHub coerces both to numbers (1 vs NaN) so it was always false and every dry-run dispatch sent real PagerDuty events — which is how a "Retry Probe (temporary): stalled" warning reached the owner at 10:25Z today (resolved manually). `inputs.dry_run == true` fixes it; verified on branch canary-probe-test run 34833513756's successor: "[dry-run] would trigger" lines, no HTTP calls. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V4AMHh8hMfZh53Tnj3TSSn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #489.
Removes
.github/workflows/_retry-probe.ymland its entry inagent-retry.yml's watched list. The end-to-end proof it existed for is recorded in the CI: retry wedged codex agent legs once; canary stops reporting them as "stalled" #489 comments.Fixes
workflow-canary.yml:DRY_RUN: ${{ inputs.dry_run == 'true' }}compared a boolean input to a string. GitHub coerces mismatched types to numbers (true→ 1,'true'→ NaN), so the expression was always false and every "dry run" dispatch sent real PagerDuty events. That is how aRetry Probe (temporary): stalled — no run in 26hwarning reached the owner at 10:25Z today while I was testing; it was resolved via the Events API from the throwaway branch. Nowinputs.dry_run == true. Verified on branchcanary-probe-test: the run prints[dry-run] would trigger …lines and makes no HTTP calls.Verified before removal (all on
main, run ids in #489 comments)legcancelled by timeout →Agent Retryfired 10 s later viarerun-failed-jobs→ attempt 2 re-ran onlyleg+finalize, both green → secondAgent Retryfiring skipped by therun_attempt == 1guard.cancelledon attempt 2, no attempt 3.failedwith conclusiontimed_out; the recovered run logs theneeded attempt 2notice.🤖 Generated with Claude Code
https://claude.ai/code/session_01V4AMHh8hMfZh53Tnj3TSSn