Skip to content

fix: grant PR attestation workflow permissions #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sythos merged 1 commit into from
Aug 25, 2026
Merged

fix: grant PR attestation workflow permissions #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/pr-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ on:

permissions:
contents: read
id-token: write
attestations: write
Comment on lines +27 to +28

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep attestation authority out of PR validation

For same-repository pull requests, this grants the checked-out PR code both an OIDC token and permission to publish repository attestations; the quality workflow subsequently executes branch-controlled npm scripts and shell commands, so a compromised internal branch can mint arbitrary attestations even though the built-in attestation step is skipped for pull_request. This also contradicts the documented boundary that PR checks are read-only and attestations come only from trusted pushes. Split the attestation work into a trusted-event job/workflow rather than delegating these write permissions to the PR caller.

Useful? React with 👍 / 👎.


concurrency:
group: pr-validation-${{ github.event.pull_request.number || github.ref }}
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ of production capacity or external service interoperability.
- [x] fast amd64-first CI with an explicit multiarch amd64+arm64 final gate;
- [x] tenant-bound DAV ETags and sync tokens;
- [x] OCI build-provenance attestations generated and verified;
- [x] pull-request validation delegates the identity-token and attestation permissions required by the provenance gate;
- [x] log rotation;
- [x] alerts;
- [x] Postfix queue visibility;
Expand Down