test(b5): recording format red tests [F#11 F#12 F#17]#150
Merged
Conversation
F#11: regression guards (tap_first persistence + replay) — fixed in #146 F#12: RED — _build_requires_block allows duplicate text_subset_required F#17: RED — migrate-recording CLI has no --all / --missing-contract flag Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- F#11 tests: all 4 pass as regression guards (fix was in main #146) - Fixed mock setup for record_act_step test (pass correct args dict) - Fixed replay test: supply matching mark for tap_first text lookup - F#12 tests: all 3 RED (build_requires_block dedup not implemented) - Fixed mark fixture to use English-dict words (high confidence_band) - F#17 tests: all 6 RED (--all/--missing-contract flags not implemented) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
F#12: deduplicate text_subset_required in _build_requires_block using a seen-set; same-text marks no longer produce duplicate entries. F#17: extend _cmd_migrate_recording with --all (batch-migrate every recording under recordings root) and --missing-contract (skip already- migrated recordings) flags; empty dir exits 0 gracefully. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tap_firstpersists in recording.yaml (fixed in fix(simdrive): persist tap_first focus context on type_text recordings (F#11) #146) and replay faithfully re-taps the focus target. 3 tests pass GREEN as regression coverage._build_requires_blockproduces duplicate entries intext_subset_requiredwhen the same text appears on both title and button (e.g. "Sign In"). 2 tests fail until dedup is added.simdrive migrate-recordingCLI has no--allor--missing-contractbatch flag; per-recording invocation required. 6 tests fail with argparse exit code 2 until flags are implemented.Test breakdown
test_record_act_step_includes_tap_first_in_argstest_tool_type_text_step_args_includes_tap_firsttest_replay_parser_accepts_and_passes_tap_firsttest_recording_yaml_roundtrip_preserves_tap_firsttest_build_requires_block_deduplicates_text_subset_requiredtest_text_subset_required_uniqueness_invarianttest_state_contract_dedup_written_to_yamltest_migrate_recording_all_migrates_every_old_recordingtest_migrate_recording_all_with_two_recordings_counttest_migrate_recording_missing_contract_skips_already_migratedtest_migrate_recording_all_handles_empty_recordings_dirtest_migrate_recording_all_flag_in_argparse_schematest_migrate_recording_missing_contract_flag_in_argparse_schemaTest plan
pytest -m "not live" tests/test_b5_domain_b_recording_format.py --tb=short→ 10 failed, 3 passed🤖 Generated with Claude Code