Skip to content

fix: constrain LoweredCodeUtils test dependency#178

Open
MilesCranmerBot wants to merge 3 commits into
SymbolicML:masterfrom
MilesCranmerBot:fix-loweredcodeutils-lower-bound
Open

fix: constrain LoweredCodeUtils test dependency#178
MilesCranmerBot wants to merge 3 commits into
SymbolicML:masterfrom
MilesCranmerBot:fix-loweredcodeutils-lower-bound

Conversation

@MilesCranmerBot

@MilesCranmerBot MilesCranmerBot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add LoweredCodeUtils as a direct test dependency
  • constrain test compat to 2, 3.4 - 3.5.99
  • keep the Julia 1.10 JET 0.9 / LoweredCodeUtils 2.x path valid while excluding the Julia-1.12-incompatible LoweredCodeUtils 3.0.x path

Validation

  • /usr/local/bin/julia --startup-file=no --project=. -e 'using TOML; TOML.parsefile("test/Project.toml")'
  • fresh Julia 1.10 test resolver/import: JET 0.9.6; LoweredCodeUtils 2.4.8
  • fresh Julia 1.12 test resolver/import: JET 0.10.14; LoweredCodeUtils 3.5.3

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master 5c4cbde... master / 5c4cbde...
eval/ComplexF32/evaluation 7.6 ± 0.55 ms 7.52 ± 0.53 ms 1.01 ± 0.1
eval/ComplexF64/evaluation 11 ± 1 ms 11 ± 0.93 ms 1 ± 0.12
eval/Float32/derivative 11.6 ± 2.5 ms 11.2 ± 2.6 ms 1.03 ± 0.32
eval/Float32/derivative_turbo 11.6 ± 2.5 ms 11.1 ± 2.5 ms 1.04 ± 0.32
eval/Float32/evaluation 2.66 ± 0.29 ms 2.64 ± 0.28 ms 1.01 ± 0.15
eval/Float32/evaluation_bumper 0.649 ± 0.019 ms 0.649 ± 0.019 ms 1 ± 0.041
eval/Float32/evaluation_turbo 0.595 ± 0.036 ms 0.609 ± 0.055 ms 0.977 ± 0.11
eval/Float32/evaluation_turbo_bumper 0.649 ± 0.017 ms 0.645 ± 0.018 ms 1.01 ± 0.039
eval/Float64/derivative 15.6 ± 4.1 ms 13.9 ± 2.4 ms 1.12 ± 0.35
eval/Float64/derivative_turbo 15.2 ± 3.9 ms 13.7 ± 2.6 ms 1.11 ± 0.35
eval/Float64/evaluation 3.2 ± 0.31 ms 3.15 ± 0.3 ms 1.02 ± 0.14
eval/Float64/evaluation_bumper 1.35 ± 0.045 ms 1.35 ± 0.044 ms 1 ± 0.047
eval/Float64/evaluation_turbo 1.13 ± 0.069 ms 1.14 ± 0.07 ms 0.995 ± 0.086
eval/Float64/evaluation_turbo_bumper 1.35 ± 0.048 ms 1.36 ± 0.042 ms 0.998 ± 0.047
utils/combine_operators/break_sharing 0.0324 ± 0.0084 ms 30.7 ± 4.2 μs 1.06 ± 0.31
utils/convert/break_sharing 28.7 ± 8.3 μs 27.9 ± 7.1 μs 1.03 ± 0.4
utils/convert/preserve_sharing 0.105 ± 0.0098 ms 0.103 ± 0.0078 ms 1.02 ± 0.12
utils/copy/break_sharing 28.8 ± 8.3 μs 31.1 ± 9.1 μs 0.927 ± 0.38
utils/copy/preserve_sharing 0.105 ± 0.0092 ms 0.104 ± 0.008 ms 1.01 ± 0.12
utils/count_constant_nodes/break_sharing 9.85 ± 1.2 μs 9.64 ± 0.96 μs 1.02 ± 0.16
utils/count_constant_nodes/preserve_sharing 0.0891 ± 0.0061 ms 0.087 ± 0.0069 ms 1.02 ± 0.11
utils/count_depth/break_sharing 10.4 ± 0.87 μs 10.5 ± 0.96 μs 0.995 ± 0.12
utils/count_nodes/break_sharing 9.56 ± 0.59 μs 9.27 ± 0.98 μs 1.03 ± 0.13
utils/count_nodes/preserve_sharing 0.0896 ± 0.0058 ms 0.0883 ± 0.0067 ms 1.02 ± 0.1
utils/get_set_constants!/break_sharing 30.5 ± 7.2 μs 26.1 ± 5.7 μs 1.17 ± 0.37
utils/get_set_constants!/preserve_sharing 0.187 ± 0.011 ms 0.184 ± 0.012 ms 1.02 ± 0.092
utils/get_set_constants_parametric 0.042 ± 0.0078 ms 0.0432 ± 0.0072 ms 0.972 ± 0.24
utils/has_constants/break_sharing 5.15 ± 0.58 μs 5.06 ± 0.48 μs 1.02 ± 0.15
utils/has_operators/break_sharing 2.66 ± 0.29 μs 2.53 ± 0.28 μs 1.05 ± 0.16
utils/hash/break_sharing 21.9 ± 1.6 μs 21.7 ± 1.5 μs 1.01 ± 0.1
utils/hash/preserve_sharing 0.107 ± 0.0073 ms 0.106 ± 0.0097 ms 1.01 ± 0.11
utils/index_constant_nodes/break_sharing 26.5 ± 4.3 μs 27.9 ± 4.3 μs 0.95 ± 0.21
utils/index_constant_nodes/preserve_sharing 0.105 ± 0.007 ms 0.104 ± 0.0071 ms 1.01 ± 0.096
utils/is_constant/break_sharing 5.54 ± 1 μs 5.28 ± 0.71 μs 1.05 ± 0.24
utils/simplify_tree/break_sharing 28.6 ± 3.4 μs 27.1 ± 3.4 μs 1.05 ± 0.18
utils/simplify_tree/preserve_sharing 0.116 ± 0.0069 ms 0.116 ± 0.0071 ms 0.997 ± 0.085
utils/string_tree/break_sharing 0.485 ± 0.019 ms 0.492 ± 0.021 ms 0.986 ± 0.057
utils/string_tree/preserve_sharing 0.584 ± 0.021 ms 0.602 ± 0.026 ms 0.969 ± 0.054
time_to_load 0.183 ± 0.0028 s 0.184 ± 0.0031 s 0.994 ± 0.023
Memory benchmarks
master 5c4cbde... master / 5c4cbde...
eval/ComplexF32/evaluation 0.981 k allocs: 2.51 MB 0.993 k allocs: 2.54 MB 0.988
eval/ComplexF64/evaluation 0.999 k allocs: 5.09 MB 1.01 k allocs: 5.15 MB 0.988
eval/Float32/derivative 4.64 k allocs: 17.5 MB 4.68 k allocs: 17.6 MB 0.991
eval/Float32/derivative_turbo 4.67 k allocs: 17.6 MB 4.65 k allocs: 17.5 MB 1.01
eval/Float32/evaluation 0.981 k allocs: 1.28 MB 0.984 k allocs: 1.28 MB 0.997
eval/Float32/evaluation_bumper 0.303 k allocs: 0.393 MB 0.303 k allocs: 0.393 MB 1
eval/Float32/evaluation_turbo 0.984 k allocs: 1.28 MB 0.966 k allocs: 1.26 MB 1.02
eval/Float32/evaluation_turbo_bumper 0.303 k allocs: 0.393 MB 0.303 k allocs: 0.393 MB 1
eval/Float64/derivative 4.73 k allocs: 0.0346 GB 4.78 k allocs: 0.0349 GB 0.99
eval/Float64/derivative_turbo 4.77 k allocs: 0.0349 GB 4.78 k allocs: 0.0349 GB 0.997
eval/Float64/evaluation 0.99 k allocs: 2.53 MB 1.01 k allocs: 2.57 MB 0.985
eval/Float64/evaluation_bumper 0.303 k allocs: 0.771 MB 0.303 k allocs: 0.771 MB 1
eval/Float64/evaluation_turbo 1.01 k allocs: 2.57 MB 0.993 k allocs: 2.54 MB 1.01
eval/Float64/evaluation_turbo_bumper 0.303 k allocs: 0.771 MB 0.303 k allocs: 0.771 MB 1
utils/combine_operators/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/convert/break_sharing 2 k allocs: 0.123 MB 2 k allocs: 0.123 MB 1
utils/convert/preserve_sharing 2.4 k allocs: 0.192 MB 2.4 k allocs: 0.192 MB 1
utils/copy/break_sharing 2 k allocs: 0.123 MB 2 k allocs: 0.123 MB 1
utils/copy/preserve_sharing 2.4 k allocs: 0.192 MB 2.4 k allocs: 0.192 MB 1
utils/count_constant_nodes/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_constant_nodes/preserve_sharing 0.404 k allocs: 0.0696 MB 0.404 k allocs: 0.0696 MB 1
utils/count_depth/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_nodes/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_nodes/preserve_sharing 0.404 k allocs: 0.0696 MB 0.404 k allocs: 0.0696 MB 1
utils/get_set_constants!/break_sharing 0.898 k allocs: 25.2 kB 0.898 k allocs: 25.2 kB 1
utils/get_set_constants!/preserve_sharing 1.7 k allocs: 0.138 MB 1.7 k allocs: 0.138 MB 1
utils/get_set_constants_parametric 1.42 k allocs: 0.0663 MB 1.42 k allocs: 0.0663 MB 1
utils/has_constants/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/has_operators/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/hash/break_sharing 0.104 k allocs: 2.52 kB 0.104 k allocs: 2.52 kB 1
utils/hash/preserve_sharing 0.504 k allocs: 0.0711 MB 0.504 k allocs: 0.0711 MB 1
utils/index_constant_nodes/break_sharing 2.1 k allocs: 0.094 MB 2.1 k allocs: 0.094 MB 1
utils/index_constant_nodes/preserve_sharing 2.5 k allocs: 0.163 MB 2.5 k allocs: 0.163 MB 1
utils/is_constant/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/simplify_tree/break_sharing 0.104 k allocs: 2.52 kB 0.104 k allocs: 2.52 kB 1
utils/simplify_tree/preserve_sharing 0.504 k allocs: 0.0711 MB 0.504 k allocs: 0.0711 MB 1
utils/string_tree/break_sharing 11.9 k allocs: 0.999 MB 11.9 k allocs: 0.999 MB 1
utils/string_tree/preserve_sharing 12.3 k allocs: 1.07 MB 12.3 k allocs: 1.07 MB 1
time_to_load 0.145 k allocs: 11 kB 0.145 k allocs: 11 kB 1

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.39%. Comparing base (efbc2aa) to head (5c4cbde).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   59.43%   59.39%   -0.04%     
==========================================
  Files          30       30              
  Lines        2682     2682              
==========================================
- Hits         1594     1593       -1     
- Misses       1088     1089       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant