Repository navigation
evidence: add structured hardware qualification workflow - #90
Conversation
|
Thanks for adding the structured hardware evidence workflow. Two independent review passes plus controller checks found no verified introduced runtime regression at this revision. This is a draft-review comment, not hardware qualification or formal merge approval. Reviewed head: Minor documentation note
Error propagation is intentional and should stayA requested capture failure now makes the bundle/session fail instead of reporting a completed capture. A base/head comparison reproduced the change from exit 0 to exit 1 for missing direct-touch input. This is the intended fail-closed correction, not a regression to revert. The real scripts were also exercised in a redirected sysfs/dev sandbox, with explicitly stubbed evtest/journalctl:
Failure artifacts/manifests remain available. README Other reviewed concerns
Executed checks / limits
No real Surface/evtest gestures, device journal traffic, cold boot/resume, kernel build or hardware equivalence was tested. The issue-form YAML was text-reviewed; no YAML-validator result is claimed. Remote checks were absent at review time. No source changes were made. |
|
Thanks — fixed the documentation mismatch. Current head: The overview now says that direct touch, beta multitouch, and stylus |
Summary
Add a focused, read-only hardware qualification workflow so independent Surface Laptop AMD results can be collected in a consistent form.
This PR does not change driver behavior.
What it adds
capture_beta_multitouch.shhelper;Beta multitouch identity
The new beta capture helper deliberately identifies the driver-owned input device by:
MSHW0231 Touchscreen;EV_ABS;BTN_TOUCH;ABS_MT_TRACKING_ID.It does not assume an
eventNnumber.That distinction matters because the standard HID child and the heatmap-backed MT bridge can coexist; a qualification run must not accidentally record the wrong device.
The beta helper is intentionally scoped to the exact MSHW0231 identity currently used by the heatmap tracker. The general report form also records MSHW0230/MSHW0162 so unrelated standard-driver results are not conflated.
Failure semantics
If
--capture-beta-multitouchis requested and that capture fails:status=trace-failed.This avoids a misleading "completed" evidence session with a missing input capture.
Safety
All added evidence helpers are read-only:
Tests
Adds
hardware_evidence_contract_test.pytomake -C tests test.It pins:
This is independent of driver PRs #87/#88 and installer PR #89.
Why this qualification workflow exists
The need for structured independent hardware evidence came directly out of the Windows reverse-engineering/qualification campaign:
This PR is the mechanism for testing whether conclusions derived from that work generalize beyond the original machine, rather than treating one-device success as broad compatibility.
Review follow-up
The README overview now explicitly says that direct touch, beta multitouch, and stylus evtest captures are opt-in. No runtime helper behavior was changed in response to review; the existing requested-capture failure propagation remains intact.