fix: number and type of gunicorn workers#1683
Open
olevski wants to merge 4 commits into
Open
Conversation
olevski
temporarily deployed
to
renku-ci-nb-1683
GitHub Actions
Inactive
Contributor
|
You can access the deployment of this PR at https://renku-ci-nb-1683.dev.renku.ch |
Panaetius
approved these changes
Jan 10, 2024
Member
|
@olevski @Panaetius should this still be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this is something that we have "always done" I think. But according to the flask docs here, when deploying with gunicorn there is no point in using
geventasync workers if you do not explicitly usegeventin your code. And we do not do this. So we get no benefit.Also we only used a single worker because we did not set anything and the default is 1.
The docs for gunicorn recommend 4-12 workers. And because in production we are kind of going for smaller many replicas rather than a large one I went for the smaller number of workers.
/deploy