Skip to content

feat: handle secrets for data connectors#413

Merged
leafty merged 12 commits into
leafty/build-data-connectorsfrom
leafty/feat-namespaced-data-connectors-5
Oct 4, 2024
Merged

feat: handle secrets for data connectors#413
leafty merged 12 commits into
leafty/build-data-connectorsfrom
leafty/feat-namespaced-data-connectors-5

Conversation

@leafty
Copy link
Copy Markdown
Member

@leafty leafty commented Sep 19, 2024 •
edited
Loading

Merging into leafty/build-data-connectors (feature branch).

Add support for saving and managing secrets for data connectors.

Details:

  • Add API endpoints to list, update and delete saved secrets for a given data connector.

@leafty leafty mentioned this pull request Sep 19, 2024
Merged
Base automatically changed from leafty/feat-namespaced-data-connectors-4 to leafty/build-data-connectors September 30, 2024 13:35
@leafty leafty force-pushed the leafty/build-data-connectors branch 2 times, most recently from 7ecf26e to 7574d13 Compare September 30, 2024 14:24
@leafty leafty force-pushed the leafty/feat-namespaced-data-connectors-5 branch from 3c45ace to d064f7b Compare September 30, 2024 14:27
@leafty leafty marked this pull request as ready for review October 2, 2024 10:57
@leafty leafty requested a review from a team as a code owner October 2, 2024 10:57
@leafty leafty mentioned this pull request Oct 3, 2024
Merged
olevski
olevski requested changes Oct 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this Flora. It may be easier to discuss my suggestions in person rather than message back and forth.

Comment thread components/renku_data_services/data_connectors/api.spec.yaml
Comment thread components/renku_data_services/data_connectors/api.spec.yaml Outdated
Comment thread components/renku_data_services/data_connectors/models.py Outdated
Comment thread components/renku_data_services/data_connectors/db.py Outdated
@olevski olevski self-requested a review October 3, 2024 14:15
olevski
olevski approved these changes Oct 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leafty this looks good. The failing test is fixed in main so if you rebase it will pass. But this is unrelated to your code so you dont have to rebase the PR if you dont want to.

@leafty
Copy link
Copy Markdown
Member Author

leafty commented Oct 3, 2024

@leafty this looks good. The failing test is fixed in main so if you rebase it will pass. But this is unrelated to your code so you dont have to rebase the PR if you dont want to.

Thanks, I will update the feature branch. I have kept it up-to-date with rebases during the build.

@leafty leafty merged commit c5820ef into leafty/build-data-connectors Oct 4, 2024
5 checks passed
@leafty leafty deleted the leafty/feat-namespaced-data-connectors-5 branch October 4, 2024 07:17
leafty added a commit that referenced this pull request Oct 4, 2024
@leafty
feat: handle secrets for data connectors (#413)
b772eef 
Add support for saving and managing secrets for data connectors.

Details:
* Add API endpoints to list, update and delete saved secrets for a given data connector.
leafty added a commit that referenced this pull request Oct 17, 2024
@leafty
feat!: add data connectors (#407)
ad4abd0 
Feature branch to add support for data connectors.

See: SwissDataScienceCenter/renku#3751.

Changes:
1. #384
2. #386
3. #406
4. #410
5. #413
6. #443
7. #422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olevski olevski olevski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leafty @olevski