🛡️ Sentinel: Harden timing-safe equality and protect Telegram from sensitive content leaks#67
Conversation
…nsitive content leaks - Hardened `safeEqual` and `safeEqualText` against length-based timing attacks by hashing both inputs with SHA-256 before constant-time comparison. - Implemented sensitive content filtering in `handleMessage` (Telegram ingestion layer) to reject messages containing secrets (API keys, passwords, etc.) before persistence. - Fixed a regression in `messageHandler.js` with an incorrect import path for `hasSensitiveContent`. - Added `frontend/tests/sentinel-security.test.js` to verify security hardening logic. - Updated Sentinel security journal in `.jules/sentinel.md`. Co-authored-by: SuvenSeo <263689617+SuvenSeo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
🛡️ Sentinel Security Hardening
This PR addresses two critical security concerns:
Timing Attack Resistance:
safeEqual(Node.js runtime) andsafeEqualText(Edge Runtime) to hash both input strings with SHA-256 before performing constant-time comparisons. This prevents length-based side-channel leaks, which could allow an attacker to guess secret lengths.proxy.jsto await the now-asynchronoussafeEqualText.Telegram Ingestion Protection:
hasSensitiveContentfiltering into the TelegramhandleMessageentry point.episodic_memory.Maintenance:
messageHandler.js.frontend/tests/sentinel-security.test.jscovering the hardened equality logic and secret detection patterns.All 37 tests in the
frontendsuite are passing.PR created automatically by Jules for task 14722682176424050829 started by @SuvenSeo