🛡️ Sentinel: [HIGH] Harden timing-safe equality checks against length leakage#61
🛡️ Sentinel: [HIGH] Harden timing-safe equality checks against length leakage#61SuvenSeo wants to merge 1 commit into
Conversation
… leakage - Hashing inputs with SHA-256 before timing-safe comparison to prevent length leakage. - Updated `safeEqual` in `auth.js` (Node.js) and `safeEqualText` in `proxy.js` (Edge). - Added security tests in `frontend/tests/security.test.js`. - Updated Sentinel journal in `.jules/sentinel.md`. Co-authored-by: SuvenSeo <263689617+SuvenSeo@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Timing-based length leakage in secret comparisons.
🎯 Impact: Attackers could potentially guess the length of secrets (passwords, tokens) by measuring response times.
🔧 Fix: Inputs are now hashed with SHA-256 before performing timing-safe comparisons, ensuring fixed-length buffers are always compared.
✅ Verification: New security tests added in
frontend/tests/security.test.jsand all existing tests pass.PR created automatically by Jules for task 5498311625573277363 started by @SuvenSeo