🛡️ Sentinel: Harden timing-safe equality checks#60
Conversation
…sed timing attacks. - Updated 'safeEqual' in 'auth.js' to hash inputs with SHA-256 before comparison. - Updated 'safeEqualText' in 'proxy.js' to hash inputs with SHA-256 before comparison (Edge-compatible). - Fixed length side-channel vulnerability where comparison returned early on length mismatch. - Added 'frontend/tests/security.test.js' to verify correctness. - Updated '.jules/sentinel.md' with security learnings. Co-authored-by: SuvenSeo <263689617+SuvenSeo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
This PR hardens the security of secret comparisons across the application. By hashing inputs with SHA-256 before performing constant-time comparisons, we eliminate a subtle length-based timing side-channel that could allow an attacker to guess the length of secrets (like API keys or session tokens) by measuring response times.
The implementation handles both the standard Node.js environment (using 'node:crypto') and the Edge Runtime (using 'crypto.subtle') to ensure reliable operation in Next.js Middleware. All 36 tests passed.
PR created automatically by Jules for task 18048440648682090257 started by @SuvenSeo