input: support Vector2 binding inversion - #422
Open
juriyivanov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for per-source Vector2 axis inversion from SteamVR/OpenVR binding
parameters:
Supported values are
x,y, andxyfor both joystick and trackpadposition bindings.
Bindings without inversion continue to use the existing direct OpenXR
suggested-binding path. Transformed sources use independent backing actions,
so inversion remains isolated by source, interaction profile, and subaction
path, and transformed and direct sources can coexist on the same OpenVR
action.
Vector2 snapshots and deltas are updated from the transformed aggregate during
UpdateActionState, preserving delta semantics across repeated reads andunread frames.
Motivation
xrizer currently ignores the Vector2
invertparameter in SteamVR/OpenVRbinding JSON. Some application bindings rely on this transform to map physical
controller axes to the coordinates expected by the application.
Related to #149.
Validation
cargo fmt --checkgit diff --checkcargo test— 95 unit tests + smoke testcargo +1.97 clippy --workspace --all-targetscargo xbuild --release --features static-openxr --verboseRuntime hardware test:
"invert": "y"Before this change the locomotion Y axis was reversed.
With the patch, forward/backward locomotion is correct on hardware.