Use released openxr 0.21 / openxr-sys 0.13 - #411
Merged
Conversation
The [patch.crates-io] pin on openxrs d0afdd3 was needed for commits that
were unreleased at the time, notably the change making
Action<Posef>::create_space take a &Session, along with the UB fix in
Instance::supports_<prop>() and the wrong-extension-check fix.
All of those shipped in openxr 0.20.0 / openxr-sys 0.12.0, so the git pin
is no longer necessary and the workspace can depend on released crates
again. This also unblocks distribution packaging, which cannot build from
a git-pinned dependency.
Moving to 0.21/0.13 needs three source changes:
* ExtensionSet::other is now Vec<Vec<u8>> holding nul-terminated
extension names rather than Vec<String>, so the XR_MNDX_xdev_space
name is passed as bytes with an explicit nul.
* openxr-sys 0.13 moves NULL/into_raw/from_raw off the inherent handle
impls onto a Handle trait, so XDev's handle accessors require
openxr::sys::Handle in scope.
* fakexr needs that same trait in scope for its own handle plumbing.
It is imported as _ there, since fakexr has an unrelated Handle
trait of its own. Only cargo test builds fakexr, so this is invisible
to a plain release build.
openxr_mndx_xdev_space moves to 0.2 to match, since 0.1.1 pins openxr
0.19.
damaestro
force-pushed
the
use-upstream-openxr-crates
branch
from
August 16, 2026 23:16
498adbd to
67284c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The [patch.crates-io] pin on openxrs d0afdd3 was needed for commits that were unreleased at the time, notably the change making Action::create_space take a &Session, along with the UB fix in Instance::supports_() and the wrong-extension-check fix.
All of those shipped in openxr 0.20.0 / openxr-sys 0.12.0, so the git pin is no longer necessary and the workspace can depend on released crates again. This also unblocks distribution packaging, which cannot build from a git-pinned dependency.
Moving to 0.21/0.13 needs two source changes:
ExtensionSet::other is now Vec<Vec> holding nul-terminated extension names rather than Vec, so the XR_MNDX_xdev_space name is passed as bytes with an explicit nul.
XDev's handle accessors require openxr::sys::Handle in scope.
openxr_mndx_xdev_space moves to 0.2 to match, since 0.1.1 pins openxr 0.19.