build: make git-describe versioning optional - #409
Merged
Conversation
vergen-gitcl shells out to git, so it only works in a git checkout. Builds from a source tarball - distribution packages, vendored builds - get the placeholder VERGEN_IDEMPOTENT_OUTPUT instead of a version, and still have to build vergen-gitcl and its dependency tree to get it. Move vergen-gitcl behind the new default-on "git-version" feature, and let any build pass its version in through the XRIZER_VERSION environment variable, which takes precedence over git describe when it is set. The default build is unchanged; builds with --no-default-features can now supply a meaningful version without a git checkout, and fall back to the version from Cargo.toml if they do not.
Supreeeme
force-pushed
the
make-vergen-optional
branch
from
September 2, 2026 01:15
ea2d998 to
7be8ef6
Compare
Supreeeme
enabled auto-merge (rebase)
September 2, 2026 01:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vergen-gitcl shells out to git, so it only works in a git checkout. Builds from a source tarball - distribution packages, vendored builds - get the placeholder VERGEN_IDEMPOTENT_OUTPUT instead of a version, and still have to build vergen-gitcl and its dependency tree to get it.
Move vergen-gitcl behind the new default-on "git-version" feature, and let any build pass its version in through the XRIZER_VERSION environment variable, which takes precedence over git describe when it is set. The default build is unchanged; builds with --no-default-features can now supply a meaningful version without a git checkout, and fall back to the version from Cargo.toml if they do not.