input: action set name handling invalid characters, allow string or number in json binding [Halo CEVR] - #406
Open
Mr-Zero88 wants to merge 2 commits into
Open
input: action set name handling invalid characters, allow string or number in json binding [Halo CEVR]#406Mr-Zero88 wants to merge 2 commits into
Mr-Zero88 wants to merge 2 commits into
Conversation
Supreeeme
reviewed
Aug 17, 2026
| }) | ||
| use serde::de::{self, Visitor}; | ||
|
|
||
| struct StringOrTypedVisitor<T>(PhantomData<T>); |
Owner
There was a problem hiding this comment.
I hate this visitor thing and I think we can avoid doing it, if we just have StringOrTyped be an enum:
#[derive(Deserialize)]
#[serde(untagged)]
enum StringOrTyped<T> {
String(String)
Typed(T)
}and have a method like fn value(&self) -> T
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.